[module_test_ios] On UITests add an additional tap on the application before tapping the element#90149
Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom Sep 17, 2021
Conversation
flutter-dashboard
bot
added
the
c: contributor-productivity
jmagman
reviewed
Sep 15, 2021
| [self waitForExpectationsWithTimeout:30.0 handler:nil]; | ||
| // Sometimes, the element doesn't respond to the tap, it seems an XCUITest bug. Trying tap | ||
| // the app first to fix it. | ||
| [self.app tap]; |
Member
There was a problem hiding this comment.
Does this tap on a random spot in the app?
Contributor
Author
There was a problem hiding this comment.
https://developer.apple.com/documentation/xctest/xcuielement/1618666-tap?language=objc "a hittable point", so I guess a random spot. Are you worried about this hitting other elements. I think the XCUITest framework should somehow find a spot that is not covered by other elements.
Member
There was a problem hiding this comment.
I'm suspicious that this won't cause problems and tap other elements, but let's try it, I don't have any better ideas.
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding an additional self.app tap see if it fixes the flake. If this doesn't, we can try to add a delay.
#89175
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.