Skip to content

Remove BottomNavigationBarItem.title deprecation#90295

Merged
fluttergithubbot merged 4 commits intoflutter:masterfrom
Piinks:bottomnav
Oct 14, 2021
Merged

Remove BottomNavigationBarItem.title deprecation#90295
fluttergithubbot merged 4 commits intoflutter:masterfrom
Piinks:bottomnav

Conversation

@Piinks
Copy link
Contributor

@Piinks Piinks commented Sep 17, 2021 •
edited
Loading

This removes the title parameter from BottomNavigationBarItem.

The replacement for which is to use label instead. This is supported by dart fix.

This deprecations has expired, as laid out in flutter.dev/go/deprecations-removed-after-2-5

Part of #90287

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Piinks Piinks added c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels. c: API break Backwards-incompatible API changes c: tech-debt Technical debt, code quality, testing, etc. labels Sep 17, 2021
@flutter-dashboard flutter-dashboard bot added f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. labels Sep 17, 2021
@flutter-dashboard
Copy link

flutter-dashboard bot commented Sep 17, 2021

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label Sep 17, 2021
@Piinks Piinks requested a review from HansMuller September 22, 2021 23:03
@Piinks
Copy link
Contributor Author

Piinks commented Sep 22, 2021 •
edited
Loading

@HansMuller can you consult on the new API? I am not sure if label should be required now.

Update: It should not be required because the Cupertino tab bar does not require it, it has a test verifying this. The material BottomNavigationBar asserts that the BottomNavigationBarItems do have a label, so it is all covered.

@Piinks Piinks changed the title [WIP] Remove BottomNavigationBarItem.title deprecation Remove BottomNavigationBarItem.title deprecation Sep 30, 2021
@Piinks Piinks requested a review from goderbauer September 30, 2021 20:42
@Piinks
Copy link
Contributor Author

Piinks commented Sep 30, 2021

Just waiting on an internal change to land, there were some lingering dart doc references.

@Piinks
Copy link
Contributor Author

Piinks commented Oct 6, 2021

Customers are migrated, this can land now.

@Piinks
Copy link
Contributor Author

Piinks commented Oct 6, 2021

@goderbauer can you approve this now that everyone is migrated?

goderbauer
goderbauer approved these changes Oct 14, 2021
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit ccc8261 into flutter:master Oct 14, 2021
Piinks added a commit that referenced this pull request Oct 15, 2021
@Piinks
Revert "Remove BottomNavigationBarItem.title deprecation (#90295)"
0427f7f 
This reverts commit ccc8261.
This was referenced Oct 15, 2021
Merged
Merged
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Oct 29, 2021
@Piinks @clocksmith
Remove BottomNavigationBarItem.title deprecation (flutter#90295)
c9587fb
@Piinks Piinks mentioned this pull request Nov 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

@HansMuller HansMuller Awaiting requested review from HansMuller

Assignees

No one assigned

Labels

c: API break Backwards-incompatible API changes c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc. f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Piinks @goderbauer @fluttergithubbot