Skip to content

Revert "Revert "Include fragment support in Android build to allow use of FragmentActivity in FlutterActivity (#9036)""#9046

Merged
collinjackson merged 1 commit intoflutter:masterfrom
collinjackson:revert_9036
Mar 28, 2017
Merged

Revert "Revert "Include fragment support in Android build to allow use of FragmentActivity in FlutterActivity (#9036)""#9046
collinjackson merged 1 commit intoflutter:masterfrom
collinjackson:revert_9036

Conversation

@collinjackson
Copy link
Contributor

Increased the time limit slightly to allow the microbenchmark test time to finish.

@collinjackson
Copy link
Contributor Author

@yjbanov

…e of FragmentActivity in FlutterActivity (flutter#9036)""

Increased the time limit slightly to allow the microbenchmark test time to finish.
@yjbanov
Copy link
Contributor

yjbanov commented Mar 28, 2017

LGTM but this will only work if a corresponding change is made in https://github.com/flutter/cocoon.

@collinjackson collinjackson merged commit 864b3c3 into flutter:master Mar 28, 2017
@collinjackson collinjackson deleted the revert_9036 branch March 28, 2017 01:12
collinjackson added a commit to collinjackson/flutter that referenced this pull request Mar 28, 2017
…allow use of FragmentActivity in FlutterActivity (flutter#9036)"" (flutter#9046)"

Test is still failing with increased timeout.

This reverts commit 864b3c3.
collinjackson added a commit that referenced this pull request Mar 28, 2017
…allow use of FragmentActivity in FlutterActivity (#9036)"" (#9046)" (#9047)

Test is still failing with increased timeout.

This reverts commit 864b3c3.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants