[module_test_ios] trying tap the buttons again if the first time didn't work#90535
Merged
fluttergithubbot merged 6 commits intoflutter:masterfrom Sep 24, 2021
Merged
Conversation
flutter-dashboard
bot
added
the
c: contributor-productivity
jmagman
reviewed
Sep 22, 2021
| [self waitForAndTapElement:app.buttons[@"Full Screen (Warm)"]]; | ||
| XCTAssertTrue([app.staticTexts[@"Button tapped 0 times."] waitForExistenceWithTimeout:60.0]); | ||
| BOOL newPageAppeared = [app.staticTexts[@"Button tapped 0 times."] waitForExistenceWithTimeout:60.0]; | ||
| if (!newPageAppeared) { |
Member
There was a problem hiding this comment.
Can you add a comment for why this is done?
|
|
||
| [self waitForAndTapElement:app.buttons[@"Full Screen (Warm)"]]; | ||
| XCTAssertTrue([app.staticTexts[@"Button tapped 0 times."] waitForExistenceWithTimeout:60.0]); | ||
| BOOL newPageAppeared = [app.staticTexts[@"Button tapped 0 times."] waitForExistenceWithTimeout:60.0]; |
Member
There was a problem hiding this comment.
I suspect 60 seconds is too long for everything in this test, but we can reevaluate once this test is stable.
Contributor
Author
There was a problem hiding this comment.
I refactored a little so all the 60.0 are now a constant, and yeah we can adjust it later.
Note that there are 2 time-outs in this tests have 30.0 time outs
Member
|
You can rebase on master to clear up the tool test errors. |
Contributor
Author
|
looks like the google testing is stuck (it's been over 24 hours), I'll re-trigger CI |
clocksmith
pushed a commit
to clocksmith/flutter
that referenced
this pull request
Oct 29, 2021
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I guess there's a race condition in the XCUITests that caused some flakiness in the tests. This PR is to try another workaround, the first try with tap on app didn't work.
#89175
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.