Reland "Enable caching of CPU samples collected at application startup (#89600)"#90611
Merged
Reland "Enable caching of CPU samples collected at application startup (#89600)"#90611
Conversation
flutter-dashboard
bot
added
the
tool
Contributor
Author
|
FYI @chunhtai, this caused a bunch of regressions last time it landed. This should have been fixed in the SDK last week so we're going to attempt to reland, but I wanted to keep the gardener in the loop just in case things blow up again. |
kenzieschmoll
approved these changes
Sep 23, 2021
bkonyi
force-pushed
the
reland_cpu_sample_caching
branch
from
c2f10f6 to
5bddcbb
Compare
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
Contributor
Author
|
google3 check is failing since the engine revision including the fix hasn't been rolled in yet. |
bkonyi
force-pushed
the
reland_cpu_sample_caching
branch
from
c873acc to
1ad4546
Compare
Contributor
Author
|
Only took 3 weeks, but I'm going to finally land this. |
bkonyi
added a commit
that referenced
this pull request
Oct 13, 2021
clocksmith
pushed a commit
to clocksmith/flutter
that referenced
this pull request
Oct 29, 2021
flutter#89600)" (flutter#90611) This reverts commit 58944e6.
clocksmith
pushed a commit
to clocksmith/flutter
that referenced
this pull request
Oct 29, 2021
…n startup (flutter#89600)" (flutter#90611)" (flutter#91754) This reverts commit e89a885.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 58944e6.