Adjust size of delete button to take up at most less than half of chip.#90845
Merged
gspencergoog merged 2 commits intoflutter:masterfrom Sep 28, 2021
Merged
Adjust size of delete button to take up at most less than half of chip.#90845gspencergoog merged 2 commits intoflutter:masterfrom
gspencergoog merged 2 commits intoflutter:masterfrom
Conversation
gspencergoog
force-pushed
the
fix_chip
branch
from
136e254 to
e2e0f51
Compare
flutter-dashboard
bot
added
f: material design
…an half of the chip.
gspencergoog
force-pushed
the
fix_chip
branch
from
e2e0f51 to
1e8e9f6
Compare
darrenaustin
approved these changes
Sep 28, 2021
| child: Column( | ||
| children: <Widget>[ | ||
| Chip( | ||
| key: chipKey, |
Contributor
There was a problem hiding this comment.
Why was this key needed?
Contributor
Author
There was a problem hiding this comment.
So I could print some values in the debug output that is no longer there. :-)
Removed.
clocksmith
pushed a commit
to clocksmith/flutter
that referenced
this pull request
Oct 29, 2021
…p. (flutter#90845) This adjusts the size of the delete button so that it takes up just slightly less than half of the chip, so that legacy tests that tap on the center of the chip still hit the chip, and not the delete button. A follow-on change for flutter#90531
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adjusts the size of the delete button so that it takes up just slightly less than half of the chip, so that legacy tests that tap on the center of the chip still hit the chip, and not the delete button.
A follow-on change for #90531
Tests