Add explicit version for mac and windows openjdk.#91408
Merged
godofredoc merged 1 commit intoflutter:masterfrom Oct 7, 2021
godofredoc:jdk_version_mac
Merged
Add explicit version for mac and windows openjdk.#91408godofredoc merged 1 commit intoflutter:masterfrom godofredoc:jdk_version_mac
godofredoc merged 1 commit intoflutter:masterfrom
godofredoc:jdk_version_mac
Conversation
Gradle was updated to a more recent version that expects openjdk 11 but the openjdk version was not updated.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
godofredoc
pushed a commit
that referenced
this pull request
Oct 8, 2021
* Revert "Mark last failing test after gradle update as flaky. (#91423)" This reverts commit 46a52d0. * Revert "fix android template for Gradle 7 (#91411)" This reverts commit 51d06d5. * Revert "Add explicit version for mac and windows openjdk. (#91408)" This reverts commit bf429f2. * Revert "Update the openjdk version used by linux android tests. (#91405)" This reverts commit 2144ab8. * Revert "Migrate to Gradle 7.0.2 / AGP 7.0.1 (#90642)" This reverts commit b6459f9.
clocksmith
pushed a commit
to clocksmith/flutter
that referenced
this pull request
Oct 29, 2021
Gradle was updated to a more recent version that expects openjdk 11 but the openjdk version was not updated.
clocksmith
pushed a commit
to clocksmith/flutter
that referenced
this pull request
Oct 29, 2021
* Revert "Mark last failing test after gradle update as flaky. (flutter#91423)" This reverts commit 46a52d0. * Revert "fix android template for Gradle 7 (flutter#91411)" This reverts commit 51d06d5. * Revert "Add explicit version for mac and windows openjdk. (flutter#91408)" This reverts commit bf429f2. * Revert "Update the openjdk version used by linux android tests. (flutter#91405)" This reverts commit 2144ab8. * Revert "Migrate to Gradle 7.0.2 / AGP 7.0.1 (flutter#90642)" This reverts commit b6459f9.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gradle was updated to a more recent version that expects openjdk 11 but the openjdk version was not updated.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.