Skip to content

Remove sandbox entitlement to allow tests to run on big sur.#92065

Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom
godofredoc:fix_mac_m1_test
Oct 19, 2021
Merged

Remove sandbox entitlement to allow tests to run on big sur.#92065
fluttergithubbot merged 1 commit intoflutter:masterfrom
godofredoc:fix_mac_m1_test

Conversation

@godofredoc
Copy link
Contributor

@godofredoc godofredoc commented Oct 19, 2021

The mac application was not allowed to run over ssh. This made the tests
fail when running from automation.

Bug: #85654

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc
Remove sandbox entitlement to allow tests to run on big sur.
396a7db 
The mac application was not allowed to run over ssh. This made the tests
fail when running from automation.

Bug: #85654
@flutter-dashboard flutter-dashboard bot added f: integration_test The flutter/packages/integration_test plugin c: contributor-productivity Team-specific productivity, code health, technical debt. labels Oct 19, 2021
@google-cla google-cla bot added the cla: yes label Oct 19, 2021
@godofredoc
Copy link
Contributor Author

godofredoc commented Oct 19, 2021

Some builds:

https://chromium-swarm.appspot.com/task?id=56af90153cd87610
https://chromium-swarm.appspot.com/task?id=56af96b0daad0c10

@godofredoc godofredoc requested a review from jmagman October 19, 2021 05:55
@jmagman
Copy link
Member

jmagman commented Oct 19, 2021

I'd rather not remove the sandbox since all our desktop apps should be running from a sandbox.
Can we instead stop passing in the codesigning overrides to the macOS test builders?

  FLUTTER_XCODE_CODE_SIGN_STYLE: Manual
  FLUTTER_XCODE_DEVELOPMENT_TEAM: S8QB4VV633
  FLUTTER_XCODE_PROVISIONING_PROFILE_SPECIFIER: match Development *

https://flutter.googlesource.com/recipes/+/refs/heads/main/recipe_modules/flutter_deps/api.py#459

The ability to stop using those iOS certs on macOS would also allow us to fix #90892.

@jmagman jmagman mentioned this pull request Oct 19, 2021
Closed
jmagman
jmagman approved these changes Oct 19, 2021
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather not remove the sandbox since all our desktop apps should be running from a sandbox. Can we instead stop passing in the codesigning overrides to the macOS test builders?

@godofredoc tried this and it didn't work in #85654 (comment)

Not sure what else to try, I'd rather have this test run than worry about the sandbox.

LGTM, thanks for the investigation, @godofredoc!

@fluttergithubbot fluttergithubbot merged commit 43bbdd0 into flutter:master Oct 19, 2021
@godofredoc godofredoc deleted the fix_mac_m1_test branch October 20, 2021 00:39
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Oct 29, 2021
@godofredoc @clocksmith
Remove sandbox entitlement to allow tests to run on big sur. (flutter…
6164106 
…#92065)
@loic-sharma loic-sharma mentioned this pull request Dec 17, 2022
Merged
8 tasks
@vashworth vashworth mentioned this pull request Aug 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmagman jmagman jmagman approved these changes

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. f: integration_test The flutter/packages/integration_test plugin

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@godofredoc @jmagman @fluttergithubbot