Reland "Refactor ThemeData (#91497)" (part 1)#92822
Merged
guidezpl merged 1 commit intoflutter:masterfrom Nov 1, 2021
guidezpl:reland-themedata
Merged
Reland "Refactor ThemeData (#91497)" (part 1)#92822guidezpl merged 1 commit intoflutter:masterfrom guidezpl:reland-themedata
guidezpl merged 1 commit intoflutter:masterfrom
guidezpl:reland-themedata
Conversation
flutter-dashboard
bot
added
f: material design
darrenaustin
approved these changes
Nov 1, 2021
Contributor
darrenaustin
left a comment
darrenaustin
left a comment
There was a problem hiding this comment.
Yeah, the ThemeData initialization code is a bit brittle and subtle. Easy to break.
LGTM.
Contributor
|
(Breaking change audit) Hey @guidezpl I noticed this was reverted for breaking internal tests, did these updates (part 1 & 2) make it non breaking? Or was the internal code migrated? If the later, this should have a migration guide under breaking changes on the website. |
Contributor
|
I am pretty sure this was an ordering issue with some initialization code. The fix was reordering it in such a way that it maintained the previous behaviour. This shouldn't be a breaking change. |
Contributor
|
Thanks @darrenaustin! :) |
WizzXu
pushed a commit
to WizzXu/flutter
that referenced
this pull request
Nov 19, 2021
8 tasks
This was referenced Feb 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reland most of #91497, which was reverted in #92820.
The re-ordering of business logic in the factory constructor seems to have caused a change in some buttons' background color. This PR includes all of #91497, minus the re-ordering of that logic.