Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
test-exempt: only rolls dependencies |
|
I am seeing this failure https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20flutter_plugins/16597/overview which looks like a timeout, but I don't have any idea how to go about trying to diagnose that? It appears to be timing out on a |
|
Ok, it looks like the issue is a version lock due to the |
|
It looks like this is now failing due to some references to package:pedantic in the analysis options files in some plugins. In particular the issue seems to be with the |
|
This should be ready to land now |

flutter update-packages --force-upgrade.Pulls in the fix for dart-lang/test#1505
Pre-launch Checklist
///).