Skip codesigning during native macOS integration tests#92938
Skip codesigning during native macOS integration tests#92938fluttergithubbot merged 4 commits intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
the
c: contributor-productivity
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
flutter-dashboard
bot
added
the
f: integration_test
|
The codesigning part worked, but the actual test being run failed: https://ci.chromium.org/p/flutter/builders/try/Mac%20native_ui_tests_macos/2 I can fix that. |
|
|
||
| - name: Mac native_ui_tests_macos | ||
| recipe: devicelab/devicelab_drone | ||
| bringup: true |
There was a problem hiding this comment.
I would suggest we validate the changes before enabled back in prod.
There was a problem hiding this comment.
I will. I'm making sure it passes in presubmit since bringup:true is skipped, and then I will change it back.
4 participants
Skip codesigning during native macOS integration test
native_ui_tests_macos.https://ci.chromium.org/p/flutter/builders/try/Mac%20native_ui_tests_macos/3
Fixes #90892