[web:tools] always use CanvasKit from the cache when building web apps#93002
Merged
yjbanov merged 1 commit intoflutter:masterfrom Nov 4, 2021
Merged
[web:tools] always use CanvasKit from the cache when building web apps#93002yjbanov merged 1 commit intoflutter:masterfrom
yjbanov merged 1 commit intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
the
tool
WizzXu
pushed a commit
to WizzXu/flutter
that referenced
this pull request
Nov 19, 2021
mdebbar
added a commit
to mdebbar/flutter
that referenced
this pull request
Mar 3, 2023
… web apps (flutter#93002)" This reverts commit 7737893.
hannah-hyj
pushed a commit
to hannah-hyj/flutter
that referenced
this pull request
Mar 11, 2023
… web apps (flutter#93002)" (flutter#117693) Revert "[web:tools] always use CanvasKit from the cache when building web apps (flutter#93002)"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
Cacheinstead ofArtifactsas the source of CanvasKit binaries.Artifactsis sensitive to--local-engineand tries to look for CanvasKit in the engine repo. However, we do not yet build CanvasKit from sources, and soArtifactsfails to find it. For now, we should always useCache. Later, when #52588 is implemented, we can change this to useArtifacts.