Deprecate primaryColorBrightness#93396
Merged
fluttergithubbot merged 10 commits intoflutter:masterfrom Nov 16, 2021
guidezpl:deprecate-primarycolorbrightness
Merged
Deprecate primaryColorBrightness#93396fluttergithubbot merged 10 commits intoflutter:masterfrom guidezpl:deprecate-primarycolorbrightness
primaryColorBrightness#93396fluttergithubbot merged 10 commits intoflutter:masterfrom
guidezpl:deprecate-primarycolorbrightness
Conversation
flutter-dashboard
bot
added
a: text input
Member
Author
|
@HansMuller Can you please review before I write a breaking change doc? Update: not a breaking change |
43 tasks
Piinks
approved these changes
Nov 15, 2021
Contributor
Piinks
left a comment
Piinks
left a comment
There was a problem hiding this comment.
LGTM! Thanks for writing dart fixes for this! :)
WizzXu
pushed a commit
to WizzXu/flutter
that referenced
this pull request
Nov 19, 2021
auto-submit bot
pushed a commit
that referenced
this pull request
May 26, 2023
…127238) ## Description Removes references to `ThemeData.primaryColorBrightness`, deprecated in #93396 and subject to remove now because of our [deprecation policy](https://github.com/flutter/flutter/wiki/Tree-hygiene#deprecations). ## Related PRs - #93396 ## Tests - Removed unneeded tests, removed references.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In line with https://flutter.dev/go/material-theme-system-updates and #91772, deprecates
primaryColorBrightness. Usages inAppBarandTextFieldare removed.A Dart fix is provided.
This is not a breaking change, per our policy. However, should this causes any issues, the documentation for
primaryColorBrightnessexplains alternatives for its former usages.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.