Skip to content

Add CupertinoSlider example#93633

Merged
fluttergithubbot merged 5 commits intoflutter:masterfrom
TahaTesser:cupertino_slider_example
Feb 14, 2022
Merged

Add CupertinoSlider example#93633
fluttergithubbot merged 5 commits intoflutter:masterfrom
TahaTesser:cupertino_slider_example

Conversation

@TahaTesser
Copy link
Contributor

@TahaTesser TahaTesser commented Nov 15, 2021 •
edited
Loading

This PR addsCupertinoSlider example

Related #72926

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the d: api docs Issues with https://api.flutter.dev/ label Nov 15, 2021
@flutter-dashboard
Copy link

flutter-dashboard bot commented Nov 15, 2021

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added d: examples Sample code and demos documentation f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Nov 15, 2021
@google-cla google-cla bot added the cla: yes label Nov 15, 2021
gspencergoog
gspencergoog reviewed Nov 15, 2021
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but will need a test.

@TahaTesser
Copy link
Contributor Author

TahaTesser commented Nov 15, 2021

@gspencergoog
Added test and cleaned up
Thank you so much for the review!

gspencergoog
gspencergoog requested changes Nov 15, 2021
View reviewed changes
@flutter-dashboard
Copy link

flutter-dashboard bot commented Dec 5, 2021

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

gspencergoog
gspencergoog approved these changes Feb 14, 2022
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@fluttergithubbot fluttergithubbot merged commit 19a380f into flutter:master Feb 14, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2022
@engine-flutter-autoroll
19a380f Add CupertinoSlider example (flutter/flutter#93633)
7c6747f
@TahaTesser TahaTesser deleted the cupertino_slider_example branch February 14, 2022 20:17
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 14, 2022
@engine-flutter-autoroll
19a380f Add CupertinoSlider example (flutter/flutter#93633)
7a920d4
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2022
@engine-flutter-autoroll
19a380f Add CupertinoSlider example (flutter/flutter#93633)
2bdef87
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 14, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 14, 2022
@engine-flutter-autoroll
19a380f Add CupertinoSlider example (flutter/flutter#93633)
9d01535
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2022
@engine-flutter-autoroll
19a380f Add CupertinoSlider example (flutter/flutter#93633)
5719b64
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2022
@engine-flutter-autoroll
19a380f Add CupertinoSlider example (flutter/flutter#93633)
43858fe
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2022
@engine-flutter-autoroll
19a380f Add CupertinoSlider example (flutter/flutter#93633)
5b2d265
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2022
@engine-flutter-autoroll
19a380f Add CupertinoSlider example (flutter/flutter#93633)
cb9f782
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2022
@engine-flutter-autoroll
19a380f Add CupertinoSlider example (flutter/flutter#93633)
bb86d6f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2022
@engine-flutter-autoroll
19a380f Add CupertinoSlider example (flutter/flutter#93633)
d8dd8d0
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2022
@engine-flutter-autoroll
19a380f Add CupertinoSlider example (flutter/flutter#93633)
0220800
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2022
@engine-flutter-autoroll
19a380f Add CupertinoSlider example (flutter/flutter#93633)
bcad660
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2022
@engine-flutter-autoroll
19a380f Add CupertinoSlider example (flutter/flutter#93633)
eb299a5
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2022
@engine-flutter-autoroll
19a380f Add CupertinoSlider example (flutter/flutter#93633)
5f8b03c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2022
@engine-flutter-autoroll
19a380f Add CupertinoSlider example (flutter/flutter#93633)
f0e1862
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2022
@engine-flutter-autoroll
19a380f Add CupertinoSlider example (flutter/flutter#93633)
1026c8f
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@TahaTesser @clocksmith
Add CupertinoSlider example (flutter#93633)
1e939e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TahaTesser @gspencergoog @fluttergithubbot