I want this one!!

It looks like the RefreshIndicator already does this though. When the ListView is reversed, the RefreshIndicator moves to the bottom, so it is always there at the leading edge of the scroll view. I think what this is trying to do is put it at the trailing edge instead.

Yeah, it does track the scroll direction properly. The request from #26758 was to have it appear at the top of the list if the ListView is using the reverse. I was just wondering if there was a way that the indicator could pick up on this without needed a new reverse parameter that would manually need to be set by the app.

Which now that I think about it, the request seems a bit odd. The whole UI gesture of 'pull down to refresh' is built on the idea that new items usually appear at the top of the list, so you scroll to the top of the list and 'pull' for more. In the case of a chat app using the reverse setting, new items will appear at the bottom, so pulling down from the top is a little odd.

@darrenaustin @Piinks
I agree that adding parameter is not the way to go. Please checkout my updated description and new code.
Let me know if there are other changes needed to improvide this behaviour, thanks

I also cloned your PR and tried running it with BouncingScrollPhysics, and refresh indicator didn't appear anywhere

@nt4f04uNd
If fidelity is not important, I would love to add something like appearAtEnd

@nt4f04uNd
Thanks for the test, I am surprised why it is broken with BouncingScrollPhysics.
I will take look into adding parameters instead as well

@nt4f04uNd @Piinks
I am not an export in scroll physics but it looks like RefreshIndicator should use AlwaysScrollableScrollPhysics, not BouncingScrollPhysics (even tho it does show an indicator without this PR for some reason)

Minimal example, this never triggers overscroll.

      body: Center(
        child: NotificationListener<OverscrollNotification>(
          onNotification: (OverscrollNotification overscroll) {
            print('overscroll: $overscroll');
            return false;
          },
          child: ListView.builder(
            reverse: true,
            physics: const BouncingScrollPhysics(),
            itemCount: 25,
            itemBuilder: (BuildContext context, int index) {
              return  ListTile(
                title: Text('List item -  $index'),
              );
            },
          ),
        ),
      ),

Also, the Troubleshooting section in the documentation also suggests this and stackoverflow

I think @TahaTesser's comment about BouncingScrollPhysics not being compatible by default makes sense. The docs for BouncingScrollPhysics even mention there are caveats to this type of ScrollPhysics triggering overscroll:

BouncingScrollPhysics by itself will not create an overscroll effect if the contents of the scroll view do not extend beyond the size of the viewport. To create the overscroll and bounce effect regardless of the length of your scroll view, combine with AlwaysScrollableScrollPhysics.

And the docs for the refresh indicator specify you need to trigger an overscroll to trigger the refresh. We may be able to make this clearer though in the docs.

Often on iOS you'll find that AlwaysScrollableScrollPhysics being used with BouncingScrollPhysics. :)

Gold has detected about 38 new digest(s) on patchset 3.
View them at https://flutter-gold.skia.org/cl/github/93779

@Piinks
Thank you so much for taking the time to test this

Looks like I missed adjusting _dragOffset, this is now fixed and I also added a test for this using BouncingScrollPhysics.

Preview

I've renamed some existing tests to match new behavior bottom doesn't seem right in the title as this PR would bring refresh indicator on top matching native behavior.

Hey @TahaTesser , I tried this code with reverse set to true but it is not working for me.

Can you please suggest what change I need to make

environment:
sdk: '>=2.12.0 <3.0.0'
flutter: '>=1.17.0'

RefreshIndicator(
            onRefresh: () async {
              //Do whatever you want on refrsh.Usually update the date of the listview
            },
            child: NotificationListener<OverscrollNotification>(
              onNotification: (OverscrollNotification overscroll) {
                print('overscroll: $overscroll');
                return true;
              },
              child: ListView.builder(
                physics: const BouncingScrollPhysics(),
                itemCount: messages.length,
                itemBuilder: (context, index) =>
                    widgetCreator.getWidget(context, messages[index]),
                reverse: true,
              ),
            ),
            color: context.colorTokens.iconDynamicDefault,
          )

Hello @TahaTesser

Do I understand correctly that RefreshIndicator is not supposed to work with reverse list view?
Messenger app is a pretty common use-case for upside-down pull-to-refresh behavior.
Now it seems impossible to achieve (except tricks with RotatedBox which won't be 100% working it changes axisdirection of list view).

Thanks

Hello @TahaTesser

Do I understand correctly that RefreshIndicator is not supposed to work with reverse list view? Messenger app is a pretty common use-case for upside-down pull-to-refresh behavior. Now it seems impossible to achieve (except tricks with RotatedBox which won't be 100% working it changes axisdirection of list view).

Thanks

I agree