Avoid using watchOS SDK in CI tests#94190
Conversation
591a43e to
f72f259
Compare
There was a problem hiding this comment.
Stop embedding the watch.
There was a problem hiding this comment.
And remove the watch as an iOS app build dependency.
There was a problem hiding this comment.
Xcode gonna Xcode, let it touch this file.
.ci.yaml
Outdated
There was a problem hiding this comment.
Since this run on a Mac_ios target, it'll still run in the devicelab. We'd need to add a separate target, like Mac ios_app_with_extensions_test.
There was a problem hiding this comment.
Thanks @CaseyHillers. I'll just revert this change for now since I don't want to try to figure out how to do that on the .ci.yaml roller failures.
christopherfujino
left a comment
There was a problem hiding this comment.
LGTM. nit should we leave a TODO or some other breadcrumb noting that this no longer actually uses a device?
|
Thanks for fixing the test, looking forward to run this test on hostonly in both presubmit and postsubmit. |
fd779e8 to
4de10d2
Compare
Good idea, done. |
Filed #94383 |
It's been a pain keeping the watchOS SDKs updated in the Xcode cipd bundles. We've needed to maintain a separate version of the depot_tools
mac_toolchain.Despite this, the newest bundle again had the watch SDK stripped out: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8829667883431985473/+/u/run_ios_app_with_extensions_test/test_stdout
Instead of fixing that bug, let's remove the need for the watchOS SDK in tests. It's currently only used in
ios_app_with_extensions_testto validate that an iOS app with a watch companion builds. See #51126 and #64674.Avoid actually building the watch app by removing the watch app as a build dependency, and stop embedding the watch in the app bundle. Instead, validate via stdout that the tool detects the watch companion, and avoids adding the
-sdkflag that used to prevent these kinds of apps from building. Build the app, but do not run on a simulator with a paired watch app.Pre-launch Checklist
///).