Don't treat stderr output as failures during DAP test teardown#94335
Don't treat stderr output as failures during DAP test teardown#94335fluttergithubbot merged 1 commit intoflutter:masterfrom DanTup:dont-throw-on-shutdown-stderr
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
test-exempt: fixes flaky test. though the precommits don't agree. :-) |
heh. I think they may be different (they look unrelated to this test) and wondered if they were related to the tree being red. I'll rebase once the tree is fixed and run them a few times to check it all looks good. Thanks! |
|
There are still some flakes here, but they seem unrelated to this change (or the flake it tries to fix), and look like the issue being tracked in #92042 (comment). So I'll re-run this until it's green (and verify the only flakes I see in the meantime are not the one this aims to fix) and then land when the tree is open. |
I think this should fix #94030.
We usually throw (to fail tests) if there is output to stderr process or a non-zero exit code during a test run. However when we're running teardown code we generally don't want this (tests aren't guaranteed to leave things cleanly, they just finish when their expectations are met and allow the teardown code to terminate the process). There was code to allow non-zero exit codes during shutdown, but not stderr output.