Skip to content

Change the TabController should make both TabBar and TabBarView return to the initial index#94339

Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom
xu-baolin:xbl001129
Dec 4, 2021
Merged

Change the TabController should make both TabBar and TabBarView return to the initial index#94339
fluttergithubbot merged 1 commit intoflutter:masterfrom
xu-baolin:xbl001129

Conversation

@xu-baolin
Copy link
Member

Fixes #93237

When changing the TabController, we only reset TabBar to the initial index and forgot to change the TabBarView index.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Nov 29, 2021
@google-cla google-cla bot added the cla: yes label Nov 29, 2021
@xu-baolin xu-baolin requested a review from goderbauer November 29, 2021 12:44
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TabView can get desynchronized with its tab controller's current index

3 participants