[tool] Add CADisableMinimumFrameDurationOnPhone to iOS templates#94509
Conversation
flutter-dashboard
bot
added
the
tool
There was a problem hiding this comment.
Instead of adding new tests for this plist value, what if you change the UIViewControllerBasedStatusBarAppearance tests to check expected Info.plist values.
flutter/packages/flutter_tools/test/commands.shard/permeable/create_test.dart
Lines 1380 to 1381 in 570e39d
final bool viewControllerBasedStatusBarAppearance = _getBooleanValueFromPlist(plistFile: plistFile, key: 'UIViewControllerBasedStatusBarAppearance');
expect(viewControllerBasedStatusBarAppearance, true);
final bool disabled = _getBooleanValueFromPlist(plistFile: plistFile, key: 'CADisableMinimumFrameDurationOnPhone');
|
I think we should wait until we have some baseline benchmarks for the devices before we land this as the default. Interested users can manually add this pref value if they desire. Once <> PR lands, users will be able to opt-in to default max frame rate by setting this manually, after that we can get some benchmarks specifically targeting lack of idle time and energy usage, we can then make this the default. I attempted to capture the sequence of steps here: #90675 (comment) |
jmagman
left a comment
jmagman
left a comment
There was a problem hiding this comment.
Code LGTM, merge when you and @iskakaushik think is best.
|
Convert to draft so we don't accidentally merge. this is blocked by #92444 |
this has been marked WONTFIX, so we should figure out next steps here. |
|
Example migration: https://gist.github.com/jmagman/d7b76fc20ff5d5808f6ce26ea3d622e9 |
cyanglaz
force-pushed
the
template_allow_max_refresh_rate
branch
from
ce899f5 to
bebfb3f
Compare
|
Gold has detected about 10 new digest(s) on patchset 3. |
cyanglaz
force-pushed
the
template_allow_max_refresh_rate
branch
from
f1f0eed to
ccb66b9
Compare
|
We need to land this to address some iPhone 13 pro issue, see: #99151 (comment) |
6 participants
This PR adds
CADisableMinimumFrameDurationOnPhoneto the iOS templates.Fixes #94508
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.