Rename devicelab catalina tests#94980
Conversation
flutter-dashboard
bot
added
the
c: contributor-productivity
|
/cc @zanderso as this will affect the benchmark data. |
| scheduler: luci | ||
|
|
||
| - name: Mac_android smoke_catalina_start_up | ||
| - name: Mac_android flutter_gallery_mac__start_up |
There was a problem hiding this comment.
Based on https://github.com/flutter/flutter/wiki/Adding-a-new-Test-Shard#steps-to-add-a-new-framework-test-shard, should we be duplicating these with bringup: true to let the name soak in?
There was a problem hiding this comment.
Based on the above doc, shall we update the framework_config.star specifically, or simply update .ci.yaml with bringup:true to wait for the roll?
There was a problem hiding this comment.
Good point :-)
Can you update the docs, and mention that renaming a target that is postsubmit only doesn't require following the bringup process?
There was a problem hiding this comment.
Will update in a separate PR.
There was a problem hiding this comment.
Added a note at the bottom: https://github.com/flutter/flutter/wiki/Adding-a-new-Test-Shard
5 participants
This PR renames:
smoke_catalina_hot_mode_dev_cycle_ios__benchmark=>hot_mode_dev_cycle_ios__benchmarksmoke_catalina_start_up=>flutter_gallery_mac__start_up(we already have one testflutter_gallery__start_upfor linux/android).This is a one time for all change on the test names, but it will affect the benchmark data which depends on test names.
#73907