Initialize the Skia client more efficiently#95055
Merged
fluttergithubbot merged 4 commits intoflutter:masterfrom Dec 11, 2021
Merged
Initialize the Skia client more efficiently#95055fluttergithubbot merged 4 commits intoflutter:masterfrom
fluttergithubbot merged 4 commits intoflutter:masterfrom
Conversation
Contributor
Author
|
FYI @kjlubick this should reduce traffic significantly. :) |
dnfield
approved these changes
Dec 11, 2021
Contributor
|
I can confirm this has reduced traffic on the Gold side. |
Contributor
Author
|
Sweet! Thanks! |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Might fix #94729
Also tracked in https://bugs.chromium.org/p/skia/issues/detail?id=12717
This moves the call to initialize into the compare method of the Flutter[Pre/Post]SubmitFileComparators. Calling it in the constructor means we might be initializing when there are no image tests being executed.
It also adds a flag to keep track of whether or not an instance of the skia client has been initialized, so we can just skip it in that case too.
Also tidied up a bit while I was at it.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.