[tool] xcresult issue discarder#95273
Merged
fluttergithubbot merged 2 commits intoflutter:masterfrom Dec 14, 2021
Merged
Conversation
flutter-dashboard
bot
added
the
tool
cyanglaz
commented
Dec 14, 2021
| return false; | ||
| } | ||
|
|
||
| List<XCResultIssue> _parseIssuesFromIssueSummariesJson({ |
Contributor
Author
There was a problem hiding this comment.
Move this private function outside of the `generate' function for cleaner code.
The changes here are adding the discarder logic.
Co-authored-by: Jenn Magder <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add [XCResultIssueDiscarder] to help discard unwanted issues.
This can be used later to discard issues that we don't want when displaying xcresults.
Fixes #95035
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.