Build Flutter iOS plugins with all valid architectures#95293
Merged
fluttergithubbot merged 2 commits intoflutter:masterfrom Dec 15, 2021
Merged
Build Flutter iOS plugins with all valid architectures#95293fluttergithubbot merged 2 commits intoflutter:masterfrom
fluttergithubbot merged 2 commits intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
the
tool
jmagman
added
platform-ios
godofredoc
added a commit
that referenced
this pull request
Dec 16, 2021
* Build Flutter iOS plugins with all valid architectures (#95293) * 'add branch flutter-2.8-candidate.3 to enabled_branches in .ci.yaml' * 'Update Engine revision to 890a5fca2e34db413be624fc83aeea8e61d42ce6 for stable release 2.8.1' Co-authored-by: Jenn Magder <[email protected]>
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Always build Flutter plugins and their dependencies with all valid iOS architectures so that, if a single plugin does not support arm64 simulators, the app and all frameworks can fall back to x86_64.
Regressed in #90915. That change started telling Xcode which device the binaries would run on, and so Xcode only built arm64 binaries on M1 Macs simulators. However
google_sign_indoesn't support arm64 simulators, so when the tool correctly dropped the executable build to x86_64, the other dependencies do not containx86_64and linking fails.Fixes #94914
Pre-launch Checklist
///).