Move flutter tests from packages/unit to packages/flutter/test#954
Move flutter tests from packages/unit to packages/flutter/test#954Hixie merged 1 commit intoflutter:masterfrom
Conversation
packages/flutter/pubspec.yaml
Outdated
There was a problem hiding this comment.
Why not move the flx tests into package/flx/test ?
There was a problem hiding this comment.
I hadn't even thought of it. Will do.
There was a problem hiding this comment.
Looks like they're already there. Maybe we don't need this dependency? This was just me merging in the dependencies we had for the unit/ directory.
|
There's really not much point having |
Hixie
force-pushed
the
unit-to-flutter
branch
from
b17602c to
c9d2d9e
Compare
|
cc @chinmaygarde: This changes the pubspec.yaml files for cassowary and newton. I couldn't work out why you depended on test_runner and dart_coveralls, is it ok to remove them? |
|
@abarth Ok, it's ready for review now. Thanks! |
Hixie
force-pushed
the
unit-to-flutter
branch
from
c9d2d9e to
13cd12e
Compare
|
@Hixie I remember I had to do that to get automatic code coverage reports sent to coveralls.io. Also, the default test hook on Travis used test_runner. We don't need those dependencies anymore though. |
|
LGTM We should check CONTRIBUTING.md to see if it refers to packages/unit anymore. |
Hixie
force-pushed
the
unit-to-flutter
branch
from
13cd12e to
7151fdd
Compare
|
patch now has updated contributor doc |
Move flutter tests from packages/unit to packages/flutter/test
3 participants
Fixes #50.