Skip to content

Report progress on Dismissible update callback#95504

Merged
fluttergithubbot merged 7 commits intoflutter:masterfrom
cachapa:dismissible_progress
Feb 5, 2022
Merged

Report progress on Dismissible update callback#95504
fluttergithubbot merged 7 commits intoflutter:masterfrom
cachapa:dismissible_progress

Conversation

@cachapa
Copy link
Contributor

@cachapa cachapa commented Dec 18, 2021 •
edited
Loading

This PR adds a progress parameter to the Dismissible onUpdate callback.
The value represents how far the dismissible child has been dragged in its parent container as a ratio value between 0.0 and 1.0, which can be useful to e.g. fade elements in sync with the gesture.

This implementation also correctly reports the position during the return animation when the dismiss is unsuccessful.

This PR partly solves #21230 (3rd. point) and closes #74582

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making.
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Dec 18, 2021
@goderbauer goderbauer requested a review from Piinks January 5, 2022 22:37
Piinks
Piinks reviewed Jan 7, 2022
View reviewed changes
packages/flutter/test/widgets/dismissible_test.dart
const double crossAxisEndOffset = 0.5;
bool reportedDismissUpdateReached = false;
bool reportedDismissUpdatePreviousReached = false;
double reportedDismissUpdateProgress = 0.0;
Copy link
Contributor

@Piinks Piinks Jan 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add tests for non-zero cases?

Copy link
Contributor Author

@cachapa cachapa Jan 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went back to check and it turns out I forgot to update the value using the callback.
It's fixed now, I'll commit shortly.

Copy link
Contributor

@Piinks Piinks Jan 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add another test that validates it reports the right value somewhere in between 0 and 1? Thanks!

Copy link
Contributor Author

@cachapa cachapa Jan 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@Piinks Piinks added f: material design flutter/packages/flutter/material repository. c: new feature Nothing broken; request for a new capability labels Jan 10, 2022
Piinks
Piinks reviewed Jan 10, 2022
View reviewed changes
packages/flutter/test/widgets/dismissible_test.dart
const double crossAxisEndOffset = 0.5;
bool reportedDismissUpdateReached = false;
bool reportedDismissUpdatePreviousReached = false;
double reportedDismissUpdateProgress = 0.0;
Copy link
Contributor

@Piinks Piinks Jan 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add another test that validates it reports the right value somewhere in between 0 and 1? Thanks!

Piinks
Piinks approved these changes Jan 21, 2022
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM! Thank you for the contribution!
I've reached out to the team for a secondary review.

@cachapa
Copy link
Contributor Author

cachapa commented Jan 21, 2022

Thanks. I'm sorry it took so long, I didn't notice that the tests were failing since last week.

Hixie
Hixie approved these changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@Hixie Hixie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cachapa
Copy link
Contributor Author

cachapa commented Feb 5, 2022

I'm kind of new to this, is there anything else required from my side?

@Hixie
Copy link
Contributor

Hixie commented Feb 5, 2022

Nope sorry, we just didn't notice it was ready to land! My bad!

@fluttergithubbot fluttergithubbot merged commit 9d2a294 into flutter:master Feb 5, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2022
@engine-flutter-autoroll
9d2a294 Report progress on Dismissible update callback (flutter/flutt…
39b7b39 
…er#95504)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2022
@engine-flutter-autoroll
9d2a294 Report progress on Dismissible update callback (flutter/flutt…
10e5daa 
…er#95504)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 6, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2022
@engine-flutter-autoroll
9d2a294 Report progress on Dismissible update callback (flutter/flutt…
3df97c3 
…er#95504)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 6, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2022
@engine-flutter-autoroll
9d2a294 Report progress on Dismissible update callback (flutter/flutt…
1c4a8ac 
…er#95504)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 6, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2022
@engine-flutter-autoroll
9d2a294 Report progress on Dismissible update callback (flutter/flutt…
cc16257 
…er#95504)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
9d2a294 Report progress on Dismissible update callback (flutter/flutt…
b72fde4 
…er#95504)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
9d2a294 Report progress on Dismissible update callback (flutter/flutt…
f46d617 
…er#95504)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
9d2a294 Report progress on Dismissible update callback (flutter/flutt…
98e9b1c 
…er#95504)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
9d2a294 Report progress on Dismissible update callback (flutter/flutt…
b7657df 
…er#95504)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
9d2a294 Report progress on Dismissible update callback (flutter/flutt…
517ef7c 
…er#95504)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
9d2a294 Report progress on Dismissible update callback (flutter/flutt…
8fa21c1 
…er#95504)
This was referenced Feb 8, 2022
Merged
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
9d2a294 Report progress on Dismissible update callback (flutter/flutt…
37ea85a 
…er#95504)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
9d2a294 Report progress on Dismissible update callback (flutter/flutt…
c4daa9b 
…er#95504)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
9d2a294 Report progress on Dismissible update callback (flutter/flutt…
55137cf 
…er#95504)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
9d2a294 Report progress on Dismissible update callback (flutter/flutt…
7ada631 
…er#95504)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
9d2a294 Report progress on Dismissible update callback (flutter/flutt…
7e86f1e 
…er#95504)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
9d2a294 Report progress on Dismissible update callback (flutter/flutt…
82763f1 
…er#95504)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
9d2a294 Report progress on Dismissible update callback (flutter/flutt…
8c64046 
…er#95504)
This was referenced Feb 9, 2022
Closed
Closed
Closed
@NATHANIELCROSBY1 NATHANIELCROSBY1 mentioned this pull request Feb 19, 2022
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hixie Hixie Hixie approved these changes

@Piinks Piinks Piinks approved these changes

Assignees

No one assigned

Labels

c: new feature Nothing broken; request for a new capability f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

expose the moveController of the Dismissible widget

4 participants

@cachapa @Hixie @Piinks @fluttergithubbot