Allow Clip.none as a valid clipBehavior#95593
Merged
Piinks merged 3 commits intoflutter:masterfrom Feb 2, 2022
Merged
Conversation
flutter-dashboard
bot
added
the
framework
Piinks
changed the title
goderbauer
reviewed
Jan 6, 2022
Piinks
added
a: layout
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 2, 2022
8 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 2, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 2, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 2, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 4, 2022
This was referenced Feb 15, 2022
clocksmith
pushed a commit
to clocksmith/flutter
that referenced
this pull request
Mar 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference internal bug: b/210103825
This makes it valid to use Clip.none as a clipBehavior, resulting in no clipping.
In cases where clipping is desired conditionally, if you were to add a clipping widget to the tree, and then remove it, Flutter is unable to preserve state in the subtree because the widget types won't match. This has become apparent in the stretching overscroll indicator where such conditional clipping is occurring.
Follow-up change should update the overscroll indicator to prevent state deactivation here:
flutter/packages/flutter/lib/src/widgets/overscroll_indicator.dart
Line 788 in 0287449
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.