Handle ListView item size changes that cause underflow#9586
Merged
HansMuller merged 4 commits intoflutter:masterfrom Apr 26, 2017
Merged
Handle ListView item size changes that cause underflow#9586HansMuller merged 4 commits intoflutter:masterfrom
HansMuller merged 4 commits intoflutter:masterfrom
Conversation
abarth
reviewed
Apr 26, 2017
Contributor
There was a problem hiding this comment.
Maybe add a comment about whether we should do this work more incrementally.
abarth
reviewed
Apr 26, 2017
Contributor
There was a problem hiding this comment.
You compute this value twice (once in the test on line 113 and again here. I'd pull the value out into a local and avoid computing it twice.
Contributor
|
|
HansMuller
force-pushed
the
listview_zero_insertion
branch
from
0556e0e to
00d57bd
Compare
a-siva
added a commit
that referenced
this pull request
Jul 2, 2019
* Manual roll of engine 45b66b7...ffba2f6 git log 45b66b7...ffba2f6 --oneline ffba2f6 Roll src/third_party/dart b37aa3b036...0abff7b2bb (#9588) 62514cb Roll fuchsia/sdk/core/mac-amd64 from n9fZpXVmsbgKZzS8Q2GXxB453q8AbLpfGztsPsq47pMC to BYCwsJf7r7zfd2THSGinFeIHv552AEVchXdc7VZzP0IC (#9587) 9f27212 Roll src/third_party/skia e4c88bb1f848..1ddee025229a (7 commits) (#9586) 03a31e0 Roll fuchsia/sdk/core/linux-amd64 from F9oY0d56X3aONxwv5vw9Gco--AHmC8SHuDXdhdWCnnMC to d2VK3FYSEKQ35UdZw5FdbOZUI_xgT0-1h8DnGDUHPVAC (#9583) * Fix analyzer warning.
johnsonmh
pushed a commit
to johnsonmh/flutter
that referenced
this pull request
Jul 30, 2019
* Manual roll of engine 45b66b7...ffba2f6 git log 45b66b7...ffba2f6 --oneline ffba2f6 Roll src/third_party/dart b37aa3b036...0abff7b2bb (flutter#9588) 62514cb Roll fuchsia/sdk/core/mac-amd64 from n9fZpXVmsbgKZzS8Q2GXxB453q8AbLpfGztsPsq47pMC to BYCwsJf7r7zfd2THSGinFeIHv552AEVchXdc7VZzP0IC (flutter#9587) 9f27212 Roll src/third_party/skia e4c88bb1f848..1ddee025229a (7 commits) (flutter#9586) 03a31e0 Roll fuchsia/sdk/core/linux-amd64 from F9oY0d56X3aONxwv5vw9Gco--AHmC8SHuDXdhdWCnnMC to d2VK3FYSEKQ35UdZw5FdbOZUI_xgT0-1h8DnGDUHPVAC (flutter#9583) * Fix analyzer warning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the heights of items at the beginning of a vertical ListView increase while the items are scrolled out of view, then correct the scroll offset when they reappear.