Deprecate useDeleteButtonTooltip for Chips#96174
Merged
fluttergithubbot merged 8 commits intoflutter:masterfrom Jan 28, 2022
Merged
Deprecate useDeleteButtonTooltip for Chips#96174fluttergithubbot merged 8 commits intoflutter:masterfrom
useDeleteButtonTooltip for Chips#96174fluttergithubbot merged 8 commits intoflutter:masterfrom
Conversation
royarg02
commented
Jan 5, 2022
royarg02
commented
Jan 5, 2022
royarg02
commented
Jan 5, 2022
royarg02
commented
Jan 5, 2022
royarg02
commented
Jan 5, 2022
royarg02
commented
Jan 5, 2022
royarg02
commented
Jan 5, 2022
royarg02
commented
Jan 5, 2022
royarg02
commented
Jan 5, 2022
royarg02
commented
Jan 5, 2022
royarg02
commented
Jan 5, 2022
royarg02
commented
Jan 5, 2022
royarg02
commented
Jan 5, 2022
royarg02
commented
Jan 5, 2022
royarg02
commented
Jan 5, 2022
royarg02
commented
Jan 5, 2022
royarg02
commented
Jan 5, 2022
royarg02
commented
Jan 5, 2022
royarg02
commented
Jan 5, 2022
royarg02
added a commit
to royarg02/website
that referenced
this pull request
Jan 6, 2022
3 tasks
useDeleteButtonTooltip for ChipsuseDeleteButtonTooltip for Chips
Contributor
Author
|
@gspencergoog The PR is (mostly) ready for review, I just have a few concerns: |
khanhnwin
pushed a commit
to flutter/website
that referenced
this pull request
Jan 7, 2022
Piinks
reviewed
Jan 7, 2022
Contributor
Piinks
left a comment
There was a problem hiding this comment.
Woohoo! Thanks for writing a dart fix! 💯
For the deprecation version, update with the latest from the master branch, and then use the version from flutter doctor.
6f6d67c to
7aa9c91
Compare
Contributor
|
Looks like there are some conflicts to resolve before it can land, unfortunately. |
016e03b to
e81a90c
Compare
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
e81a90c to
0fb626c
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 28, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 28, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 4, 2022
3 tasks
clocksmith
pushed a commit
to clocksmith/flutter
that referenced
this pull request
Mar 8, 2022
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR deprecates
useDeleteButtonTooltip, forChipwidgets that support having a delete button. This includes theChip, theInputChipand theRawChipwidget.Instead, to disable the tooltips on the delete button of these chips, users should pass an empty string to
deleteButtonTooltipMessage.A dart fix is provided.
The migration code is shown below:
Before:
After:
The design doc for this change can be found here.
This is not a breaking change as it is only deprecating a property.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.