Text selection located wrong position when selecting multiple lines over max lines#96471
Closed
SuhwanCha wants to merge 4 commits intoflutter:masterfrom
SuhwanCha:b96453
Closed
Text selection located wrong position when selecting multiple lines over max lines#96471SuhwanCha wants to merge 4 commits intoflutter:masterfrom SuhwanCha:b96453
SuhwanCha wants to merge 4 commits intoflutter:masterfrom
SuhwanCha:b96453
Conversation
flutter-dashboard
bot
added
a: text input
|
Gold has detected about 2 new digest(s) on patchset 2. |
|
Gold has detected about 2 new digest(s) on patchset 3. |
Contributor
|
cc @justinmc for one more approval |
justinmc
reviewed
Jan 27, 2022
Contributor
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
This doesn't seem to work in every case. I tried it when the field is vertically centered in the app and the toolbar shows up in the wrong place:
Code
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({
Key? key,
}) : super(key: key);
@override
Widget build(BuildContext context) {
return MaterialApp(
title: 'Flutter Demo',
theme: ThemeData(
primarySwatch: Colors.blue,
),
home: Scaffold(
appBar: AppBar(
title: const Text('Flutter Demo'),
),
body: const Center(
child: TextField(
maxLines: 2,
),
),
),
);
}
}Unfortunately our existing tests didn't catch that.
Contributor
|
@SuhwanCha I'm going to close this since it's been stale for awhile and has merge conflicts. If you still want to fix this bug, feel free to let me know and I'm happy to help with reviews. |
This was referenced Apr 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #96453
This PR fixes bugs that text selection located wrong position when selecting multiple lines over max lines.
Pre-launch Checklist
///).