Expose keyCode field in RawKeyEventDataWeb.#96483
Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom Jan 12, 2022
b-luk:master
Merged
Expose keyCode field in RawKeyEventDataWeb.#96483fluttergithubbot merged 1 commit intoflutter:masterfrom b-luk:master
fluttergithubbot merged 1 commit intoflutter:masterfrom
b-luk:master
Conversation
flutter-dashboard
bot
added
the
framework
Contributor
|
Adding @gspencergoog for a second review. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jan 18, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jan 18, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jan 18, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose keyCode field in RawKeyEventDataWeb. The field is piped through from related PR: flutter/engine#30801
This has been discussed with and approved by @dkwingsmt. For more context (Google internal doc): https://docs.google.com/document/d/1inEHNhqglzlqQKCkRWYiC9wWn0tus-U3BXiuENqTfv8/edit?usp=sharing&resourcekey=0-WmlMQRjj1YLFE0BgGGDoZA
List which issues are fixed by this PR. You must list at least one issue.
Fixes #96479
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.