Skip to content

PopupMenu: add themeable mouse cursor v2#96567

Merged
HansMuller merged 1 commit intoflutter:masterfrom
HansMuller:popup_menu_mouse_cursor
Jan 14, 2022
Merged

PopupMenu: add themeable mouse cursor v2#96567
HansMuller merged 1 commit intoflutter:masterfrom
HansMuller:popup_menu_mouse_cursor

Conversation

@HansMuller
Copy link
Contributor

Support overriding the mouseCursor for PopupMenuItems with PopupMenuTheme.

This PR is based on #88590 (author @jpnurmi). It additionally addresses #88590 (comment). PR #88590 wasn't reviewed for months by yours truly, so I'm completing the project here.

Partial fix to #88371

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jan 13, 2022
Copy link
Contributor

@darrenaustin darrenaustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@HansMuller HansMuller merged commit 1612310 into flutter:master Jan 14, 2022
@HansMuller HansMuller deleted the popup_menu_mouse_cursor branch January 14, 2022 19:53
@jpnurmi jpnurmi mentioned this pull request Jan 16, 2022
8 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jan 18, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jan 18, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jan 18, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 4, 2022
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants