FloatingActionButton: add themeable mouse cursor#96714
FloatingActionButton: add themeable mouse cursor#96714jpnurmi wants to merge 14 commits intoflutter:masterfrom
Conversation
werainkhatri
left a comment
There was a problem hiding this comment.
Thanks for updating the API.
I just have a few suggestions.
packages/flutter/lib/src/material/floating_action_button_theme.dart
Outdated
Show resolved
Hide resolved
packages/flutter/test/material/floating_action_button_theme_test.dart
Outdated
Show resolved
Hide resolved
…st.dart Co-authored-by: Viren Khatri <[email protected]>
|
Hi @werainkhatri, thanks for the review. Sorry that this has taken so long, I completely forgot this... I left some comments/answers to your suggestions. Let me know if I misunderstood any. |
| extendedIconLabelSpacing: lerpDouble(a?.extendedIconLabelSpacing, b?.extendedIconLabelSpacing, t), | ||
| extendedPadding: EdgeInsetsGeometry.lerp(a?.extendedPadding, b?.extendedPadding, t), | ||
| extendedTextStyle: TextStyle.lerp(a?.extendedTextStyle, b?.extendedTextStyle, t), | ||
| mouseCursor: t < 0.5 ? a?.mouseCursor : b?.mouseCursor, |
There was a problem hiding this comment.
ideally this needs to be tested but FloatingActionButtonThemeData.lerp itself is not tested :(
|
hey! looks like a check is failing, could you take a look? |
|
I think the failure was sorted out by flutter/tests#123 and flutter/tests#124. |
|
FWIW, the latest customer tests did pass locally. customer_testing/run_tests.dart``` Starting run_tests.dart... 8 files specified.Tests: Processing ./registry/assorted_layout_widgets.test...
Processing ./registry/DanTup_tiler.test...
Processing ./registry/flutter_gallery.test...
| Applying fixes...
Processing ./registry/flutter_packages.test...
Processing ./registry/flutter_reactive_ble.test...
Processing ./registry/flutter_svg.test...
Processing ./registry/provider.test...
Processing ./registry/rainbowmonkey.test...
13 tests all passed! |
|
maybe try rebasing? also fyi there are a few conflicts. |
|
Linux web_tests_5 failures seem unrelated: |
|
The issue with |
|
There are no references to https://github.com/dnfield/flutter_svg/blob/master/golden/simple/text_5.png |
|
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
So, merging upstream didn't help but unrelated customer tests would keep failing. Creating a new PR with the same changes did pass the CI, though: #96714 |

Allow themes to override FloatingActionButton's mouse cursor.
Partial fix to #88371
Pre-launch Checklist
///).