Skip to content

BottomNavigationBar: add themeable mouse cursor#96736

Merged
HansMuller merged 2 commits intoflutter:masterfrom
NevercodeHQ:bottom_nav_cursor
Feb 2, 2022
Merged

BottomNavigationBar: add themeable mouse cursor#96736
HansMuller merged 2 commits intoflutter:masterfrom
NevercodeHQ:bottom_nav_cursor

Conversation

@TahaTesser
Copy link
Contributor

@TahaTesser TahaTesser commented Jan 17, 2022 •
edited
Loading

Allow themes to override BottomNavigationBar's mouse cursor.

Partial fix to #88371

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jan 17, 2022
@TahaTesser TahaTesser changed the title BottomNavigationBar: add themeable mouse cursor BottomNavigationBar: add theameable mouse cursor Jan 17, 2022
@TahaTesser TahaTesser changed the title BottomNavigationBar: add theameable mouse cursor BottomNavigationBar: add themeable mouse cursor Jan 17, 2022
@TahaTesser TahaTesser mentioned this pull request Jan 17, 2022
Open
8 tasks
@TahaTesser TahaTesser requested a review from HansMuller January 17, 2022 14:09
HansMuller
HansMuller reviewed Feb 1, 2022
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, just needs some tiny API doc tweaks.

@TahaTesser
BottomNavigationBar: add themeable mouse cursor
b1c4684 
Remove trailing space

Updates fromr review
@HansMuller
Copy link
Contributor

HansMuller commented Feb 1, 2022

There's a typo that's causing docs-linux to fail:

Found unresolved dartdoc directives in dev/docs/doc/api/material/BottomNavigationBar/mouseCursor.html:
  {@endtemplate}

@TahaTesser
Copy link
Contributor Author

TahaTesser commented Feb 1, 2022

There's a typo that's causing docs-linux to fail:

Found unresolved dartdoc directives in dev/docs/doc/api/material/BottomNavigationBar/mouseCursor.html:
  {@endtemplate}

Ooops, my bad. Fixed

HansMuller
HansMuller approved these changes Feb 1, 2022
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HansMuller HansMuller merged commit 7a4f5eb into flutter:master Feb 2, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2022
@engine-flutter-autoroll
7a4f5eb BottomNavigationBar: add themeable mouse cursor (flutter/flut…
29d1772 
…ter#96736)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2022
@engine-flutter-autoroll
7a4f5eb BottomNavigationBar: add themeable mouse cursor (flutter/flut…
3629081 
…ter#96736)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2022
@engine-flutter-autoroll
7a4f5eb BottomNavigationBar: add themeable mouse cursor (flutter/flut…
c35b0a0 
…ter#96736)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 2, 2022
Merged
@TahaTesser TahaTesser deleted the bottom_nav_cursor branch February 2, 2022 07:25
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 4, 2022
@engine-flutter-autoroll
7a4f5eb BottomNavigationBar: add themeable mouse cursor (flutter/flut…
494eb2e 
…ter#96736)
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@TahaTesser @clocksmith
BottomNavigationBar: add themeable mouse cursor (flutter#96736)
cb69895
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@HansMuller HansMuller HansMuller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

Nevercode
Status: Done (PR merged)

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TahaTesser @HansMuller