Skip to content

TabBar: add themeable mouse cursor #96737

Merged
fluttergithubbot merged 2 commits intoflutter:masterfrom
NevercodeHQ:tabbar_cursor
Feb 8, 2022
Merged

TabBar: add themeable mouse cursor #96737
fluttergithubbot merged 2 commits intoflutter:masterfrom
NevercodeHQ:tabbar_cursor

Conversation

@TahaTesser
Copy link
Contributor

@TahaTesser TahaTesser commented Jan 17, 2022 •
edited
Loading

Allow themes to override TabBar's mouse cursor.

Partial fix to #88371

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jan 17, 2022
@TahaTesser TahaTesser changed the title TabBar: add theameable mouse cursor TabBar: add themeable mouse cursor Jan 17, 2022
@TahaTesser TahaTesser mentioned this pull request Jan 17, 2022
Open
8 tasks
@TahaTesser TahaTesser requested a review from HansMuller January 17, 2022 14:09
@HansMuller
Copy link
Contributor

HansMuller commented Feb 7, 2022

Currently unable to review this because "Server Error". I've contacted GitHub support.

@TahaTesser
Copy link
Contributor Author

TahaTesser commented Feb 7, 2022 •
edited
Loading

Currently unable to review this because "Server Error". I've contacted GitHub support.

Thank you, I've been experiencing this issue all day today.

@HansMuller
Copy link
Contributor

HansMuller commented Feb 7, 2022

It appears to have been fixed!

HansMuller
HansMuller reviewed Feb 7, 2022
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some small stuff

@TahaTesser TahaTesser requested a review from HansMuller February 7, 2022 20:05
@TahaTesser
TabBar: add theameable mouse cursor
d33c63d 
fix doc template

Remove trailing space

Rename test variable

minor fixes
HansMuller
HansMuller approved these changes Feb 7, 2022
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I missed one tiny formatting issue.

@fluttergithubbot fluttergithubbot merged commit a6504ea into flutter:master Feb 8, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
a6504ea TabBar: add themeable mouse cursor (flutter/flutter#96737)
f5aa9b5
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
a6504ea TabBar: add themeable mouse cursor (flutter/flutter#96737)
63e5519
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
a6504ea TabBar: add themeable mouse cursor (flutter/flutter#96737)
082beab
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
a6504ea TabBar: add themeable mouse cursor (flutter/flutter#96737)
60feb92
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
a6504ea TabBar: add themeable mouse cursor (flutter/flutter#96737)
078d5f8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
a6504ea TabBar: add themeable mouse cursor (flutter/flutter#96737)
1cc93a4
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
a6504ea TabBar: add themeable mouse cursor (flutter/flutter#96737)
43c8dc1
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
a6504ea TabBar: add themeable mouse cursor (flutter/flutter#96737)
faa9562
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
a6504ea TabBar: add themeable mouse cursor (flutter/flutter#96737)
39f395a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
a6504ea TabBar: add themeable mouse cursor (flutter/flutter#96737)
0295b90
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
a6504ea TabBar: add themeable mouse cursor (flutter/flutter#96737)
a64cad1
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
a6504ea TabBar: add themeable mouse cursor (flutter/flutter#96737)
004bcb0
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
a6504ea TabBar: add themeable mouse cursor (flutter/flutter#96737)
985e340
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
a6504ea TabBar: add themeable mouse cursor (flutter/flutter#96737)
8e65424
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
a6504ea TabBar: add themeable mouse cursor (flutter/flutter#96737)
0365d56
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
a6504ea TabBar: add themeable mouse cursor (flutter/flutter#96737)
f210b50
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
a6504ea TabBar: add themeable mouse cursor (flutter/flutter#96737)
743a123
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
a6504ea TabBar: add themeable mouse cursor (flutter/flutter#96737)
171088b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
a6504ea TabBar: add themeable mouse cursor (flutter/flutter#96737)
a0ad115
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
a6504ea TabBar: add themeable mouse cursor (flutter/flutter#96737)
5907889
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
a6504ea TabBar: add themeable mouse cursor (flutter/flutter#96737)
a7e7a3e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
a6504ea TabBar: add themeable mouse cursor (flutter/flutter#96737)
ef91be7
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@TahaTesser @clocksmith
TabBar: add themeable mouse cursor (flutter#96737)
484bad5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@HansMuller HansMuller HansMuller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

Nevercode
Status: Done (PR merged)

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TahaTesser @HansMuller @fluttergithubbot