CupertinoButton: Add clickable cursor on web by TahaTesser · Pull Request #96863 · flutter/flutter

TahaTesser · 2022-01-19T15:56:26Z

Integration test for web results:

CupertinoButton

Launching integration_test/cupertino/cupertino_button.dart on Chrome in debug mode...
integration_test/cupertino/cupertino_button.dart:1
DartUri: Unresolved uri: dart:web_sql
DartUri: Unresolved uri: dart:ui

This app is linked to the debug service: ws://127.0.0.1:53522/VuUlt7P2VyM=/ws
Debug service listening on ws://127.0.0.1:53522/VuUlt7P2VyM=/ws
💪 Running with sound null safety 💪
Connecting to VM Service at ws://127.0.0.1:53522/VuUlt7P2VyM=/ws
00:00 +0: Hovering over Cupertino button updates cursor to clickable on Web
00:00 +1: (tearDownAll)
00:00 +2: All tests passed!

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Renzo-Olivares

Very straightforward implementation! I think it would be good for the test to also test when the mouse is not hovering over the button.

Another thing I noticed on macOS-web is that for buttons/tab-bars/and other clickable items there is a subtle highlight associated with a hover over the element. Though I did not find anything in regards to it on https://developer.apple.com/design/human-interface-guidelines/macos/user-interaction/

packages/flutter/test/cupertino/button_test.dart

Remove trailing space Update test

TahaTesser · 2022-03-04T12:54:59Z

@Renzo-Olivares
Actually tested the test on the web using integration_test, it works as expected after updating the test, results in the description.

Renzo-Olivares

LGTM thank you for addressing all my comments!

TahaTesser · 2022-03-04T22:28:39Z

@Renzo-Olivares
My pleasure! Appreciate you taking the time to review these Cupertino PRs

I've filed a bunch of other related PRs, I followed the same pattern and tested those as well using integration_test to make sure the web is in fact updating the cursor and following the same title pattern for all of them.

…#96863)

flutter-dashboard bot added f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels. labels Jan 19, 2022

TahaTesser mentioned this pull request Jan 19, 2022

Cupertino widgets don't change mouse cursor when hover on web #86174

Closed

Renzo-Olivares reviewed Mar 2, 2022

View reviewed changes

Renzo-Olivares self-assigned this Mar 2, 2022

TahaTesser force-pushed the cupertinobutton_web_cursor branch from 1bfddb6 to 5eac917 Compare March 3, 2022 08:59

Renzo-Olivares requested changes Mar 3, 2022

View reviewed changes

packages/flutter/test/cupertino/button_test.dart Outdated Show resolved Hide resolved

TahaTesser added 2 commits March 4, 2022 00:53

CupertinoButton: Add clickable cursor on web

58355e6

Remove trailing space Update test

Update test title

33a4c03

TahaTesser force-pushed the cupertinobutton_web_cursor branch from 5eac917 to 33a4c03 Compare March 3, 2022 22:53

TahaTesser requested a review from Renzo-Olivares March 3, 2022 23:09

Update test

79b3108

Renzo-Olivares approved these changes Mar 4, 2022

View reviewed changes

TahaTesser added the waiting for tree to go green label Mar 4, 2022

fluttergithubbot merged commit 4b902c7 into flutter:master Mar 4, 2022

engine-flutter-autoroll mentioned this pull request Mar 4, 2022

Roll Flutter from 513df67edb69 to 4b902c79ce0c (2 revisions) flutter/plugins#5008

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 4, 2022

4b902c7 CupertinoButton: Add clickable cursor on web (flutter/flutter…

7bc7a0f

…#96863)

engine-flutter-autoroll mentioned this pull request Mar 4, 2022

Roll Flutter from 38dbbb17f8ce to 4b902c79ce0c (54 revisions) flutter/packages#1061

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 4, 2022

4b902c7 CupertinoButton: Add clickable cursor on web (flutter/flutter…

ddce104

…#96863)

TahaTesser deleted the cupertinobutton_web_cursor branch March 4, 2022 23:38

engine-flutter-autoroll mentioned this pull request Mar 4, 2022

Roll Flutter from 513df67edb69 to 59859df1265a (3 revisions) flutter/plugins#5009

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 4, 2022

4b902c7 CupertinoButton: Add clickable cursor on web (flutter/flutter…

5f05f3d

…#96863)

engine-flutter-autoroll mentioned this pull request Mar 4, 2022

Roll Flutter from 38dbbb17f8ce to 8e6d57b7735a (56 revisions) flutter/packages#1062

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 4, 2022

4b902c7 CupertinoButton: Add clickable cursor on web (flutter/flutter…

cd51dd6

…#96863)

engine-flutter-autoroll mentioned this pull request Mar 5, 2022

Roll Flutter from 38dbbb17f8ce to 03c92a99fdf8 (57 revisions) flutter/packages#1063

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 5, 2022

4b902c7 CupertinoButton: Add clickable cursor on web (flutter/flutter…

0244913

…#96863)

engine-flutter-autoroll mentioned this pull request Mar 5, 2022

Roll Flutter from 513df67edb69 to 03c92a99fdf8 (5 revisions) flutter/plugins#5010

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 5, 2022

4b902c7 CupertinoButton: Add clickable cursor on web (flutter/flutter…

f0536fe

…#96863)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2022

4b902c7 CupertinoButton: Add clickable cursor on web (flutter/flutter…

4fd5769

…#96863)

engine-flutter-autoroll mentioned this pull request Mar 7, 2022

Roll Flutter from 38dbbb17f8ce to 66826e8fefb9 (84 revisions) flutter/packages#1109

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2022

4b902c7 CupertinoButton: Add clickable cursor on web (flutter/flutter…

806e1ff

…#96863)

engine-flutter-autoroll mentioned this pull request Mar 7, 2022

Roll Flutter from 38dbbb17f8ce to 4f7d7b56191d (85 revisions) flutter/packages#1110

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2022

4b902c7 CupertinoButton: Add clickable cursor on web (flutter/flutter…

824268a

…#96863)

engine-flutter-autoroll mentioned this pull request Mar 7, 2022

Roll Flutter from 38dbbb17f8ce to 4c591bc755c4 (86 revisions) flutter/packages#1111

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2022

4b902c7 CupertinoButton: Add clickable cursor on web (flutter/flutter…

826ebc6

…#96863)

engine-flutter-autoroll mentioned this pull request Mar 7, 2022

Roll Flutter from 38dbbb17f8ce to 10805ca3fe6b (87 revisions) flutter/packages#1112

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2022

4b902c7 CupertinoButton: Add clickable cursor on web (flutter/flutter…

2ec25ef

…#96863)

engine-flutter-autoroll mentioned this pull request Mar 7, 2022

Roll Flutter from 38dbbb17f8ce to 8f58af8b8ce9 (88 revisions) flutter/packages#1113

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2022

4b902c7 CupertinoButton: Add clickable cursor on web (flutter/flutter…

71c30f8

…#96863)

engine-flutter-autoroll mentioned this pull request Mar 8, 2022

Roll Flutter from 38dbbb17f8ce to 23ea5120d4f2 (89 revisions) flutter/packages#1114

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2022

4b902c7 CupertinoButton: Add clickable cursor on web (flutter/flutter…

a16c590

…#96863)

engine-flutter-autoroll mentioned this pull request Mar 8, 2022

Roll Flutter from 38dbbb17f8ce to c188930554b7 (90 revisions) flutter/packages#1115

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2022

4b902c7 CupertinoButton: Add clickable cursor on web (flutter/flutter…

98cb6a6

…#96863)

engine-flutter-autoroll mentioned this pull request Mar 8, 2022

Roll Flutter from 38dbbb17f8ce to c15ec6a13e5d (91 revisions) flutter/packages#1116

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2022

4b902c7 CupertinoButton: Add clickable cursor on web (flutter/flutter…

c5249ae

…#96863)

engine-flutter-autoroll mentioned this pull request Mar 8, 2022

Roll Flutter from 38dbbb17f8ce to 5ae4885e5edd (92 revisions) flutter/packages#1117

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2022

4b902c7 CupertinoButton: Add clickable cursor on web (flutter/flutter…

9feddc7

…#96863)

clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022

CupertinoButton: Add clickable cursor on web (flutter#96863)

d5c433e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CupertinoButton: Add clickable cursor on web#96863

CupertinoButton: Add clickable cursor on web#96863
fluttergithubbot merged 3 commits intoflutter:masterfrom
NevercodeHQ:cupertinobutton_web_cursor

TahaTesser commented Jan 19, 2022 •

edited

Loading

Uh oh!

Renzo-Olivares left a comment •

edited

Loading

Uh oh!

Uh oh!

TahaTesser commented Mar 4, 2022 •

edited

Loading

Uh oh!

Renzo-Olivares left a comment •

edited

Loading

Uh oh!

TahaTesser commented Mar 4, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

TahaTesser commented Jan 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Integration test for web results: