Skip to content

CupertinoTabBar: Add clickable cursor on web#96996

Merged
fluttergithubbot merged 4 commits intoflutter:masterfrom
NevercodeHQ:cupertinotabbar_web_cursor
Mar 7, 2022
Merged

CupertinoTabBar: Add clickable cursor on web#96996
fluttergithubbot merged 4 commits intoflutter:masterfrom
NevercodeHQ:cupertinotabbar_web_cursor

Conversation

@TahaTesser
Copy link
Contributor

@TahaTesser TahaTesser commented Jan 21, 2022 •
edited
Loading

partial fix for #86174

Complete details #86174 (comment)

Integration test for web results:

CupertinoTabBar

Launching integration_test/cupertino/cupertino_tab_bar.dart on Chrome in debug mode...
integration_test/cupertino/cupertino_tab_bar.dart:1
DartUri: Unresolved uri: dart:web_sql
DartUri: Unresolved uri: dart:ui

This app is linked to the debug service: ws://127.0.0.1:55352/htWEd61mxMk=/ws
Debug service listening on ws://127.0.0.1:55352/htWEd61mxMk=/ws
💪 Running with sound null safety 💪
Connecting to VM Service at ws://127.0.0.1:55352/htWEd61mxMk=/ws
00:00 +0: Hovering over tab bar item updates cursor to clickable on Web
00:00 +1: (tearDownAll)
00:00 +2: All tests passed!

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels. labels Jan 21, 2022
@TahaTesser TahaTesser mentioned this pull request Jan 21, 2022
Closed
Renzo-Olivares
Renzo-Olivares reviewed Mar 2, 2022
View reviewed changes
Copy link
Contributor

@Renzo-Olivares Renzo-Olivares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to my review on CupertinoButton. A test for when the cursor is not hovering on top of the button would be good.

@Renzo-Olivares Renzo-Olivares self-assigned this Mar 2, 2022
@TahaTesser TahaTesser force-pushed the cupertinotabbar_web_cursor branch from 8cc0ebe to b8bc08f Compare March 3, 2022 09:25
Renzo-Olivares
Renzo-Olivares requested changes Mar 3, 2022
View reviewed changes
@TahaTesser
CupertinoTabBar: Add clickable cursor on web
10ecf6a 
Remove trailing space

Kick tests

Update test
@TahaTesser
Update test
708741a
@TahaTesser TahaTesser force-pushed the cupertinotabbar_web_cursor branch from b8bc08f to 708741a Compare March 3, 2022 23:06
@TahaTesser
Copy link
Contributor Author

TahaTesser commented Mar 3, 2022

@Renzo-Olivares
Thanks so much for the review, appreciate it!

I intend to make similar changes to other Cupertino widgets ASAP. I wanted to some confirmation with these two current PRs.

@TahaTesser
Copy link
Contributor Author

TahaTesser commented Mar 4, 2022 •
edited
Loading

@Renzo-Olivares
Actually tested the test on the web using integration_test, it works as expected after updating the test, results in the description.

Renzo-Olivares
Renzo-Olivares approved these changes Mar 7, 2022
View reviewed changes
Copy link
Contributor

@Renzo-Olivares Renzo-Olivares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fluttergithubbot fluttergithubbot merged commit 4f7d7b5 into flutter:master Mar 7, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 7, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 7, 2022
@engine-flutter-autoroll
4f7d7b5 CupertinoTabBar: Add clickable cursor on web (flutter/flutter…
8b8681a 
…#96996)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 7, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2022
@engine-flutter-autoroll
4f7d7b5 CupertinoTabBar: Add clickable cursor on web (flutter/flutter…
c34d6c0 
…#96996)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 7, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2022
@engine-flutter-autoroll
4f7d7b5 CupertinoTabBar: Add clickable cursor on web (flutter/flutter…
182682d 
…#96996)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 7, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2022
@engine-flutter-autoroll
4f7d7b5 CupertinoTabBar: Add clickable cursor on web (flutter/flutter…
77c6e61 
…#96996)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 7, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 7, 2022
@engine-flutter-autoroll
4f7d7b5 CupertinoTabBar: Add clickable cursor on web (flutter/flutter…
76d876d 
…#96996)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 7, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2022
@engine-flutter-autoroll
4f7d7b5 CupertinoTabBar: Add clickable cursor on web (flutter/flutter…
0b803ae 
…#96996)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
4f7d7b5 CupertinoTabBar: Add clickable cursor on web (flutter/flutter…
af28f0d 
…#96996)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
4f7d7b5 CupertinoTabBar: Add clickable cursor on web (flutter/flutter…
6161274 
…#96996)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
4f7d7b5 CupertinoTabBar: Add clickable cursor on web (flutter/flutter…
b7adfcc 
…#96996)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
4f7d7b5 CupertinoTabBar: Add clickable cursor on web (flutter/flutter…
00da951 
…#96996)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
4f7d7b5 CupertinoTabBar: Add clickable cursor on web (flutter/flutter…
7a403fa 
…#96996)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
4f7d7b5 CupertinoTabBar: Add clickable cursor on web (flutter/flutter…
afc8f46 
…#96996)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
4f7d7b5 CupertinoTabBar: Add clickable cursor on web (flutter/flutter…
ed4ed3a 
…#96996)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
4f7d7b5 CupertinoTabBar: Add clickable cursor on web (flutter/flutter…
8c7354b 
…#96996)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
4f7d7b5 CupertinoTabBar: Add clickable cursor on web (flutter/flutter…
91ee48d 
…#96996)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
4f7d7b5 CupertinoTabBar: Add clickable cursor on web (flutter/flutter…
cc67f17 
…#96996)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
4f7d7b5 CupertinoTabBar: Add clickable cursor on web (flutter/flutter…
3bc48f4 
…#96996)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
4f7d7b5 CupertinoTabBar: Add clickable cursor on web (flutter/flutter…
6dfb2ab 
…#96996)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
4f7d7b5 CupertinoTabBar: Add clickable cursor on web (flutter/flutter…
afb9858 
…#96996)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2022
@engine-flutter-autoroll
4f7d7b5 CupertinoTabBar: Add clickable cursor on web (flutter/flutter…
79b8a81 
…#96996)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2022
@engine-flutter-autoroll
4f7d7b5 CupertinoTabBar: Add clickable cursor on web (flutter/flutter…
f427242 
…#96996)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2022
@engine-flutter-autoroll
4f7d7b5 CupertinoTabBar: Add clickable cursor on web (flutter/flutter…
68d8886 
…#96996)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2022
@engine-flutter-autoroll
4f7d7b5 CupertinoTabBar: Add clickable cursor on web (flutter/flutter…
73e4549 
…#96996)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Renzo-Olivares Renzo-Olivares Renzo-Olivares approved these changes

Assignees

@Renzo-Olivares Renzo-Olivares

Labels

f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TahaTesser @Renzo-Olivares @fluttergithubbot