fix(date-picker): Fix cupertino date picker minuteInterval#97012
fix(date-picker): Fix cupertino date picker minuteInterval#97012ansolantz wants to merge 1 commit intoflutter:masterfrom
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Hi, @ansolantz |
Hi @SuhwanCha, |
|
@ansolantz that fix is probably correct (i honestly don't know the code well enough to say for sure) but @SuhwanCha is right, before we can review it it really needs a test. You can find the other datepicker tests here: https://github.com/flutter/flutter/blob/master/packages/flutter/test/cupertino/date_picker_test.dart |
|
Thanks for the contribution! I'm going to close this PR since it needs tests, as per the comments above. If anyone wants to take over please don't hesitate to take this code and submit a new PR! |
The Cupertino date picker does not work correctly when using minuteInterval and scrolling past the endDate
List which issues are fixed by this PR. You must list at least one issue.
Issue 97010
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.