Add NavigationBar dartpad example by maheshj01 · Pull Request #97046 · flutter/flutter

maheshj01 · 2022-01-22T06:32:58Z

This PR adds a dartpad example for Material 3 NavigationBar

Addresses #96750

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

packages/flutter/lib/src/material/navigation_bar.dart

maheshj01 · 2022-01-25T10:15:34Z

The checks failure looks related to #89243

packages/flutter/lib/src/material/navigation_bar.dart

HansMuller

The example will need a test, see examples/api/test

HansMuller · 2022-01-28T20:28:27Z

examples/api/lib/material/navigation_bar/navigation_bar.dart

There are some trivial formatting issues here and the code can be simplified a little

import 'package:flutter/material.dart'; void main() { runApp(const MyApp()); } class MyApp extends StatelessWidget { const MyApp({ Key? key }) : super(key: key); @override Widget build(BuildContext context) { return const MaterialApp(home: NavigationExample()); } } class NavigationExample extends StatefulWidget { const NavigationExample({Key? key}) : super(key: key); @override State<NavigationExample> createState() => _NavigationExampleState(); } class _NavigationExampleState extends State<NavigationExample> { int currentPageIndex = 0; @override Widget build(BuildContext context) { return Scaffold( bottomNavigationBar: NavigationBar( onDestinationSelected: (int index) { setState(() { currentPageIndex = index; }); }, selectedIndex: currentPageIndex, destinations: const <Widget>[ NavigationDestination( icon: Icon(Icons.explore), label: 'Explore', ), NavigationDestination( icon: Icon(Icons.commute), label: 'Commute', ), NavigationDestination( selectedIcon: Icon(Icons.bookmark), icon: Icon(Icons.bookmark_border), label: 'Saved', ), ], ), body: <Widget>[ Container( color: Colors.red, alignment: Alignment.center, child: const Text('Page 1'), ), Container( color: Colors.green, alignment: Alignment.center, child: const Text('Page 2'), ), Container( color: Colors.blue, alignment: Alignment.center, child: const Text('Page 3'), ), ][currentPageIndex], ); } }

Could you please specify what formatting needs to be done? Regarding the sample code, I have simplified it further.

I had reformatted your example per https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo. That was the comment (above) was. Please try and align your updated example with what I'd written.

Thanks, I have formatted the sample code as per above

maheshj01 · 2022-02-01T18:08:20Z

The example will need a test, see examples/api/test

Thanks for reviewing, I have added basic tests. let me know if you want me to add more scenarios.

HansMuller · 2022-02-01T18:35:46Z

examples/api/lib/material/navigation_bar/navigation_bar.dart

I had reformatted your example per https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo. That was the comment (above) was. Please try and align your updated example with what I'd written.

HansMuller · 2022-02-02T18:57:42Z

@maheshmnj - the test failures aren't related to this PR. Please sync with master and push an empty commit to get the tests to run again.

HansMuller · 2022-02-08T18:23:52Z

@dnfield, @jason-simmons - this docs-only PR, which AFAICT should have no effect on Flutter's contributed tests, has been failing the following rfw and svg tests for at least a week. Maybe it has something to do with flutter/tests#124?

| 00:41 +79: /tmp/flutter_customer_testing.flutter_packages.DODKXB/tests/packages/rfw/test/argument_decoders_test.dart: golden checks
| ══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
| The following assertion was thrown while running async test code:
| Golden "goldens/argument_decoders_test.text.png": Pixel test failed, 0.10% diff detected.
| Failure feedback can be found at
| /tmp/flutter_customer_testing.flutter_packages.DODKXB/tests/packages/rfw/test/failures
|
| When the exception was thrown, this was the stack:
| #0      LocalFileComparator.compare (package:flutter_test/src/_goldens_io.dart:102:7)
| <asynchronous suspension>
| <asynchronous suspension>
| (elided one frame from package:stack_trace)
| ════════════════════════════════════════════════════════════════════════════════════════════════════
|
| 00:41 +79 -1: /tmp/flutter_customer_testing.flutter_packages.DODKXB/tests/packages/rfw/test/argument_decoders_test.dart: golden checks [E]
|   Test failed. See exception logs above.
|   The test description was: golden checks

 00:38 +39 -1: /tmp/flutter_customer_testing.flutter_svg.HCYFXP/tests/test/golden_svg_test.dart: SVG Rendering matches golden files [E]
|   Expected: pairwise components nearly equal to [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, ...]
|     Actual: [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, ...]
|      Which: has <255> which is not components nearly equal to <232> at index 52161
|   /tmp/flutter_customer_testing.flutter_svg.HCYFXP/tests/golden/simple/text_5.png does not match rendered output of /tmp/flutter_customer_testing.flutter_svg.HCYFXP/tests/example/assets/simple/text_5.svg!
|
|   package:test_api                expect
|   test/golden_svg_test.dart 48:7  main.<fn>
|

maheshj01 · 2022-02-25T16:45:01Z

Hi, just checking if there is anything on my side to fix 1 failing checkmark.

HansMuller · 2022-02-25T18:03:30Z

Per @dnfield - the source of the problem is likely the logic used to pick a commit for customer testing. A merge will not fix the issue, this PR needs to be rebased.

maheshj01 · 2022-02-26T04:18:32Z

Oops! it's still failing here's what I did

git checkout master 
git pull remote master
git checkout navigation-bar-docs
git rebase master
/// resolved conflicts
git add .
git rebase --continue
git push  /// failed
git push -f

Let me know if I missed anything

Thanks

dnfield · 2022-02-28T17:14:33Z

@maheshmnj - I think something like this should work:

git fetch remote
git rebase remote/master
# resolve conflicts
git push -f

Alternatively, just start a fresh PR with these changes that's based on the most recent commit from master.

The only other time I've seen these two failures (on flutter_svg and rfw) it was related to this issue. The branch was forked from a commit behind where the customer testing was updated to account for golden file changes.

dnfield · 2022-02-28T17:17:09Z

This PR is still getting a relatively old commit of flutter/tests - flutter/tests@1943e74 - a properly done rebase should resolve that, but sometimes git is finnicky about that. If another rebase attempt does not fix this I would just close the PR and open a new one with these changes applied on a fresh branch.

HansMuller · 2022-02-28T17:31:13Z

My git skills are limited and so I have to admit that I'd take Dan's advice about just creating a fresh PR - #97046 (comment). Sometimes that's the easiest way to deal with this kind of thing.

Co-authored-by: Viren Khatri <[email protected]>

maheshj01 · 2022-03-01T03:44:14Z

Thanks for the suggestion @dnfield luckily the rebase worked out.

HansMuller

LGTM

The requested change was made

maheshj01 changed the title ~~Navigation bar docs~~ Adds Navigation bar dartpad example Jan 22, 2022

maheshj01 changed the title ~~Adds Navigation bar dartpad example~~ Add Navigation bar dartpad example Jan 22, 2022

maheshj01 changed the title ~~Add Navigation bar dartpad example~~ Add NavigationBar dartpad example Jan 22, 2022

2002Bishwajeet reviewed Jan 22, 2022

View reviewed changes

packages/flutter/lib/src/material/navigation_bar.dart Outdated Show resolved Hide resolved

werainkhatri previously requested changes Jan 25, 2022

View reviewed changes

packages/flutter/lib/src/material/navigation_bar.dart Outdated Show resolved Hide resolved

HansMuller reviewed Jan 28, 2022

View reviewed changes

HansMuller suggested changes Feb 1, 2022

View reviewed changes

maheshj01 and others added 7 commits March 1, 2022 08:42

add navigation bar example

8cf7d3d

update example

2610bac

add dartpad example with example description

36a559d

add license header

d3ffeb1

fix analyzer warnings

46f02c3

remove comma

080b9a6

add tests for navigation bar example

a5b1c27

maheshj01 and others added 3 commits March 1, 2022 08:42

fix: incorrect example path

f9f2640

Co-authored-by: Viren Khatri <[email protected]>

simplify example

1182542

format code as per style guide

c829143

HansMuller approved these changes Mar 1, 2022

View reviewed changes

HansMuller merged commit 0038a3e into flutter:master Mar 1, 2022

engine-flutter-autoroll mentioned this pull request Mar 1, 2022

Roll Flutter from e85ba6eeae67 to 0038a3e29fb3 (3 revisions) flutter/packages#989

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2022

0038a3e Add NavigationBar dartpad example (flutter/flutter#97046)

440d64a

engine-flutter-autoroll mentioned this pull request Mar 1, 2022

Roll Flutter from e85ba6eeae67 to 078deb9230be (4 revisions) flutter/packages#990

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2022

0038a3e Add NavigationBar dartpad example (flutter/flutter#97046)

4f4b265

Piinks mentioned this pull request Mar 1, 2022

DOC: Improve Navigation Bar Docs #96750

Closed

engine-flutter-autoroll mentioned this pull request Mar 1, 2022

Roll Flutter from 8b95cd6f35b7 to 1dd24b8af858 (9 revisions) flutter/plugins#4970

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 1, 2022

0038a3e Add NavigationBar dartpad example (flutter/flutter#97046)

32bae2f

clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022

Add NavigationBar dartpad example (flutter#97046)

c1e97f1

Conversation

maheshj01 commented Jan 22, 2022

Pre-launch Checklist

Uh oh!

Uh oh!

maheshj01 commented Jan 25, 2022

Uh oh!

Uh oh!

HansMuller left a comment

Choose a reason for hiding this comment

Uh oh!

HansMuller Jan 28, 2022

Choose a reason for hiding this comment

Uh oh!

maheshj01 Feb 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

HansMuller Feb 1, 2022

Choose a reason for hiding this comment

Uh oh!

maheshj01 Feb 2, 2022

Choose a reason for hiding this comment

Uh oh!

maheshj01 commented Feb 1, 2022

Uh oh!

HansMuller Feb 1, 2022

Choose a reason for hiding this comment

Uh oh!

HansMuller commented Feb 2, 2022

Uh oh!

HansMuller commented Feb 8, 2022

Uh oh!

maheshj01 commented Feb 25, 2022

Uh oh!

HansMuller commented Feb 25, 2022

Uh oh!

maheshj01 commented Feb 26, 2022

Uh oh!

dnfield commented Feb 28, 2022

Uh oh!

dnfield commented Feb 28, 2022

Uh oh!

HansMuller commented Feb 28, 2022

Uh oh!

maheshj01 commented Mar 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

HansMuller left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

maheshj01 Feb 1, 2022 •

edited

Loading

maheshj01 commented Mar 1, 2022 •

edited

Loading