Conversation
There was a problem hiding this comment.
we really should factor out these docs into an interface at the foundation layer.
There was a problem hiding this comment.
some of these should be plural, e.g. zero or more [UserScrollNotification]s
There was a problem hiding this comment.
actually this will fire when it hasn't changed its scroll position, but would have. Basically it's what translates into a glow. On iOS this never fires.
There was a problem hiding this comment.
this description of OverscrollNotification is incorrect, I believe.
There was a problem hiding this comment.
"the sooner it stops" is probably less odd-sounding that "the faster it slows down". :-)
There was a problem hiding this comment.
I think modeling is the American spelling
There was a problem hiding this comment.
that => that a
[Here and elsewhere]
There was a problem hiding this comment.
It would be helpful to explain when the dragDetails are non-null, i.e. the drag gesture ended with a velocity that was too small to trigger a ballistic scroll.
There was a problem hiding this comment.
The docs for particle/position/velocity talk about a "particle". We should probably explain the particle angle here or define those methods in terms of the simulation's position; and then mention that position is usually mapped to scroll offset.
There was a problem hiding this comment.
Maybe call attention to of() and ensureVisible() here, since those methods will not appear with ListView et al.
There was a problem hiding this comment.
It's not clear what this means. The property is used to map from input gestures to scroll offset deltas?
There was a problem hiding this comment.
Maybe see-also ensureVisible()
|
LGTM too, just some nits. |
|
Thanks! |
No description provided.