Fix flutter view project's automated tests#9712
Merged
xster merged 3 commits intoflutter:masterfrom May 2, 2017
Merged
Conversation
xster
changed the title
Member
Author
|
Related #9580 |
yjbanov
approved these changes
May 2, 2017
| reportMetrics: false, | ||
| // This project has a non-standard CocoaPods Podfile. Run pod install | ||
| // before building the project. | ||
| customPodFile: true, |
Contributor
There was a problem hiding this comment.
I'd call this parameter runPodInstall to make it more obvious what the effect of this option is. It may not always be clear that custom POD file leads to an extra pod install command.
Hixie
added a commit
that referenced
this pull request
May 2, 2017
…9719) * Revert "Document ScrollController (#9705)" This reverts commit ff8609f. * Revert "Fix channels integration test (#9713)" This reverts commit aace622. * Revert "Fix flutter view project's automated tests (#9712)" This reverts commit 1a4bf9b. * Revert "Update hello_world_memory_test package name (#9704)" This reverts commit ffa8483. * Revert "Increment the flutter package version (#9699)" This reverts commit 3b237a8. * Revert "Don’t pod unless there are plugins (#9701)" This reverts commit 732f79e.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since it uses non-standard Podfile, we should treat it as if the user wrote his own custom Podfile in which case flutter shouldn't auto-manage pod executions for the user. Let the user run pod install himself and accommodate it in automated devicelab tests.