Skip to content

Do not build for iOS armv7#97341

Merged
fluttergithubbot merged 4 commits intoflutter:masterfrom
jmagman:exclude-armv7
Apr 12, 2022
Merged

Do not build for iOS armv7#97341
fluttergithubbot merged 4 commits intoflutter:masterfrom
jmagman:exclude-armv7

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Jan 27, 2022 •
edited
Loading

Exclude armv7 so apps will not build for 32-bit iOS devices. App's plugins dependencies will also not be built with armv7.

On this PR when I target a 32-bit device in Xcode it correctly tells me I can't run on an armv device:
Screen Shot 2022-01-26 at 2 06 05 PM

Blocked by #97339, do not merge. This has merged.

Fixes #97328.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. t: xcode "xcodebuild" on iOS and general Xcode project management labels Jan 27, 2022
@jmagman jmagman self-assigned this Jan 27, 2022
@jmagman jmagman marked this pull request as ready for review April 8, 2022 02:10
@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Apr 8, 2022
christopherfujino
christopherfujino approved these changes Apr 8, 2022
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman jmagman mentioned this pull request Apr 8, 2022
Closed
8 tasks
@jmagman
Copy link
Member Author

jmagman commented Apr 11, 2022

Waiting for the current g3 roll to merge for branch alignment.

@jmagman
Copy link
Member Author

jmagman commented Apr 12, 2022

#97339 has merged.

@fluttergithubbot fluttergithubbot merged commit d4bfb01 into flutter:master Apr 12, 2022
@jmagman jmagman deleted the exclude-armv7 branch April 12, 2022 21:44
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 12, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 12, 2022
@engine-flutter-autoroll
d4bfb01 Do not build for iOS armv7 (flutter/flutter#97341)
865a50a
This was referenced Apr 12, 2022
Merged
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 13, 2022
@engine-flutter-autoroll
d4bfb01 Do not build for iOS armv7 (flutter/flutter#97341)
94f355f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 13, 2022
@engine-flutter-autoroll
d4bfb01 Do not build for iOS armv7 (flutter/flutter#97341)
afded40
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 13, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 13, 2022
@engine-flutter-autoroll
d4bfb01 Do not build for iOS armv7 (flutter/flutter#97341)
10b5bcc
@jmagman jmagman mentioned this pull request Apr 14, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. platform-ios iOS applications specifically t: xcode "xcodebuild" on iOS and general Xcode project management tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Exclude arm7v from iOS architectures when building iOS app and plugins

3 participants

@jmagman @christopherfujino @fluttergithubbot