PointerDeviceKind and ui.PointerChange forwards-compatibility#97350
PointerDeviceKind and ui.PointerChange forwards-compatibility#97350dkwingsmt merged 3 commits intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
a: text input
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
dkwingsmt
left a comment
dkwingsmt
left a comment
There was a problem hiding this comment.
Add comment for linter comments per style guide.
moffatman
force-pushed
the
trackpad_gestures_prep
branch
from
d038e1d to
05e8cb0
Compare
| return buttons == 0 ? kPrimaryButton : buttons; | ||
| case PointerDeviceKind.unknown: | ||
| // ignore: no_default_cases, to allow adding new device types to [PointerDeviceKind]. | ||
| default: |
There was a problem hiding this comment.
is this temporary? if so please leave a todo here with a link to the issue where the work is happening
There was a problem hiding this comment.
Can we make it permanent? Because this enum is always subject to adding new options.
Or what if we just remove unknown, since that's what "unknown" is for.
There was a problem hiding this comment.
removing "unknown" seems fine to me, i don't really understand how "unknown" would ever get set in the first place
|
IF this change is temporary and there's a commitment to a timeline to removing it: test-exempt: temporary code to allow rolling |
…r#97350) * PointerDeviceKind and ui.PointerChange forwards-compatibility * Add link to trackpad gestures issue * Add TODO
3 participants
Needed to prepare framework for engine changes to support trackpad gestures (flutter/engine#28571)
Pre-launch Checklist
///).