[ci] Remove ios32 tests by CaseyHillers · Pull Request #97385 · flutter/flutter

CaseyHillers · 2022-01-27T17:00:18Z

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
All existing and new tests are passing.

keyonghan

@jmagman @zanderso do we still want to keep those two test dart files? If not, we may also need to clean up the TESTOWNERS.

/dev/devicelab/bin/tasks/native_ui_tests_ios.dart
/dev/devicelab/bin/tasks/flutter_gallery__transition_perf_e2e_ios32.dart

godofredoc · 2022-01-27T18:02:51Z

.ci.yaml

      os: Mac-12.0
      device_os: iOS-15.1
      xcode: 13a233
-  mac_ios32:


Do we run these tests on release branches?

Yes. We can let this roll through the release process, or we can CP it into the next releases

jmagman

@zanderso should we do this before the 32-bit iOS devices are only supported as part of the “Best Effort” tier announcement?

https://flutter.dev/go/rfc-32-bit-ios-support#heading=h.8pjtgh69i9ph

jmagman · 2022-01-27T18:45:18Z

@jmagman @zanderso do we still want to keep those two test dart files? If not, we may also need to clean up the TESTOWNERS.
/dev/devicelab/bin/tasks/native_ui_tests_ios.dart
/dev/devicelab/bin/tasks/flutter_gallery__transition_perf_e2e_ios32.dart

We should remove flutter_gallery__transition_perf_e2e_ios32 but native_ui_tests_ios is still used in the non-32 bit Mac_ios native_ui_tests_ios test.

zanderso · 2022-01-28T17:30:32Z

@zanderso should we do this before the 32-bit iOS devices are only supported as part of the “Best Effort” tier announcement?

This can happen as soon as we no longer need to test the 2.10 beta/stable release. /cc @godofredoc for when that will be.

godofredoc · 2022-01-28T17:55:47Z

pen as soon as we no longer need to test the 2.10 beta/stable

We can land this change, next Friday.

CaseyHillers · 2022-02-07T17:51:45Z

Now that 2.10 has shipped, should we remove these tests?

jmagman

This still needs the TESTOWNERS change, but other than that @godofredoc says it's good to land, and the change will get cherry-picked in the next hotfix.

jmagman · 2022-02-07T18:22:51Z

This still needs the TESTOWNERS change, but other than that @godofredoc says it's good to land, and the change will get cherry-picked in the next hotfix.

Here:

flutter/TESTOWNERS

Lines 169 to 171 in ba01ec8

    
           ## Mac iOS32 DeviceLab tests 
        
           /dev/devicelab/bin/tasks/flutter_gallery__transition_perf_e2e_ios32.dart @zanderso @flutter/engine

jmagman

LGTM!

jmagman · 2022-02-07T22:00:10Z

Google testing looks stuck, there's nothing in FRoB for this PR...

CaseyHillers · 2022-02-07T23:19:14Z

Google testing looks stuck, there's nothing in FRoB for this PR...

\cc @renyou @angjieli I tried creating it from the FRoB UI, but it says the check already existed for the commit

angjieli · 2022-02-07T23:26:10Z

Feel free to manually merge it. I will take a look at the internal issue.

[ci] Remove ios32 tests

8452465

CaseyHillers requested a review from keyonghan as a code owner January 27, 2022 17:00

CaseyHillers requested a review from jmagman January 27, 2022 17:00

keyonghan reviewed Jan 27, 2022

View reviewed changes

godofredoc reviewed Jan 27, 2022

View reviewed changes

jmagman reviewed Jan 27, 2022

View reviewed changes

Rm flutter_gallery__transition_per_e2e_ios32

7560d8c

goderbauer added c: contributor-productivity Team-specific productivity, code health, technical debt. team-infra Owned by Infrastructure team labels Feb 1, 2022

jmagman reviewed Feb 7, 2022

View reviewed changes

Remove test owner for transition perf e2e ios32

afccf9a

CaseyHillers mentioned this pull request Feb 7, 2022

Test owners should fail if unnecessary owners are added #97969

Closed

jmagman approved these changes Feb 7, 2022

View reviewed changes

CaseyHillers added the waiting for tree to go green label Feb 7, 2022

CaseyHillers merged commit 3f7d997 into flutter:master Feb 8, 2022

CaseyHillers deleted the ios32-ci-deprecation branch February 8, 2022 03:24

engine-flutter-autoroll mentioned this pull request Feb 8, 2022

Roll Flutter from 185bc093e04b to 3f7d997c3ac5 (57 revisions) flutter/packages#726

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022

3f7d997 [ci] Remove ios32 tests (flutter/flutter#97385)

fe24907

engine-flutter-autoroll mentioned this pull request Feb 8, 2022

Roll Flutter from f483b7d80831 to 3f7d997c3ac5 (19 revisions) flutter/plugins#4752

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 8, 2022

3f7d997 [ci] Remove ios32 tests (flutter/flutter#97385)

bda8404

engine-flutter-autoroll mentioned this pull request Feb 8, 2022

Roll Flutter from 185bc093e04b to 213f766e35d6 (58 revisions) flutter/packages#727

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022

3f7d997 [ci] Remove ios32 tests (flutter/flutter#97385)

3348d92

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 8, 2022

3f7d997 [ci] Remove ios32 tests (flutter/flutter#97385)

88d77ac

engine-flutter-autoroll mentioned this pull request Feb 8, 2022

Roll Flutter from f483b7d80831 to 4f975cbe2fc9 (36 revisions) flutter/packages#745

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022

3f7d997 [ci] Remove ios32 tests (flutter/flutter#97385)

212749b

engine-flutter-autoroll mentioned this pull request Feb 9, 2022

Roll Flutter from f483b7d80831 to 4f975cbe2fc9 (36 revisions) flutter/plugins#4766

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022

3f7d997 [ci] Remove ios32 tests (flutter/flutter#97385)

20dfc4c

engine-flutter-autoroll mentioned this pull request Feb 9, 2022

Roll Flutter from f483b7d80831 to 9eb94c59b8cd (38 revisions) flutter/plugins#4767

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022

3f7d997 [ci] Remove ios32 tests (flutter/flutter#97385)

9177675

engine-flutter-autoroll mentioned this pull request Feb 9, 2022

Roll Flutter from f483b7d80831 to 63f48d1ff8db (39 revisions) flutter/plugins#4768

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022

3f7d997 [ci] Remove ios32 tests (flutter/flutter#97385)

7ad35f1

engine-flutter-autoroll mentioned this pull request Feb 9, 2022

Roll Flutter from f483b7d80831 to 3bdea6bb925a (40 revisions) flutter/plugins#4769

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022

3f7d997 [ci] Remove ios32 tests (flutter/flutter#97385)

ecbd9e5

engine-flutter-autoroll mentioned this pull request Feb 9, 2022

Roll Flutter from f483b7d80831 to ae3f99c98af7 (41 revisions) flutter/plugins#4770

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022

3f7d997 [ci] Remove ios32 tests (flutter/flutter#97385)

26ff465

engine-flutter-autoroll mentioned this pull request Feb 9, 2022

Roll Flutter from f483b7d80831 to d2853dce6c14 (43 revisions) flutter/plugins#4771

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022

3f7d997 [ci] Remove ios32 tests (flutter/flutter#97385)

dabe214

engine-flutter-autoroll mentioned this pull request Feb 9, 2022

Roll Flutter from f483b7d80831 to 3669e3669a89 (44 revisions) flutter/plugins#4772

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022

3f7d997 [ci] Remove ios32 tests (flutter/flutter#97385)

be30642

engine-flutter-autoroll mentioned this pull request Feb 9, 2022

Roll Flutter from f483b7d80831 to 499e900e3952 (45 revisions) flutter/plugins#4773

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022

3f7d997 [ci] Remove ios32 tests (flutter/flutter#97385)

46e72cd

engine-flutter-autoroll mentioned this pull request Feb 9, 2022

Roll Flutter from f483b7d80831 to c54a27dc8790 (46 revisions) flutter/plugins#4774

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022

3f7d997 [ci] Remove ios32 tests (flutter/flutter#97385)

a0ea206

engine-flutter-autoroll mentioned this pull request Feb 9, 2022

Roll Flutter from f483b7d80831 to 312085a19a0f (47 revisions) flutter/plugins#4775

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022

3f7d997 [ci] Remove ios32 tests (flutter/flutter#97385)

1fdcbd2

engine-flutter-autoroll mentioned this pull request Feb 9, 2022

Roll Flutter from f483b7d80831 to ca647d1e9a5d (48 revisions) flutter/plugins#4776

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022

3f7d997 [ci] Remove ios32 tests (flutter/flutter#97385)

f395ebb

engine-flutter-autoroll mentioned this pull request Feb 9, 2022

Roll Flutter from f483b7d80831 to bb3275b9340f (51 revisions) flutter/plugins#4778

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022

3f7d997 [ci] Remove ios32 tests (flutter/flutter#97385)

e0558b9

clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022

[ci] Remove ios32 tests (flutter#97385)

4d8a140

This was referenced Apr 12, 2022

☂️ Remove support for 32-bit iOS devices #97327

Closed

Mark 32-bit iOS platform as unsupported flutter/website#7016

Merged

Conversation

CaseyHillers commented Jan 27, 2022

Pre-launch Checklist

Uh oh!

keyonghan left a comment

Choose a reason for hiding this comment

Uh oh!

godofredoc Jan 27, 2022

Choose a reason for hiding this comment

Uh oh!

CaseyHillers Jan 27, 2022

Choose a reason for hiding this comment

Uh oh!

jmagman left a comment

Choose a reason for hiding this comment

Uh oh!

jmagman commented Jan 27, 2022

Uh oh!

zanderso commented Jan 28, 2022

Uh oh!

godofredoc commented Jan 28, 2022

Uh oh!

CaseyHillers commented Feb 7, 2022

Uh oh!

jmagman left a comment

Choose a reason for hiding this comment

Uh oh!

jmagman commented Feb 7, 2022

Uh oh!

jmagman left a comment

Choose a reason for hiding this comment

Uh oh!

jmagman commented Feb 7, 2022

Uh oh!

CaseyHillers commented Feb 7, 2022

Uh oh!

angjieli commented Feb 7, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants