CocoaPods flow step 2 - don't pod install unless project has plugins#9741
Merged
xster merged 2 commits intoflutter:masterfrom May 3, 2017
Merged
CocoaPods flow step 2 - don't pod install unless project has plugins#9741xster merged 2 commits intoflutter:masterfrom
xster merged 2 commits intoflutter:masterfrom
Conversation
xster
changed the title
Member
Author
|
cc @cbracken we talked about some related stuff |
collinjackson
approved these changes
May 3, 2017
Contributor
mravn-google
approved these changes
May 3, 2017
Contributor
mravn-google
left a comment
mravn-google
left a comment
There was a problem hiding this comment.
LGTM on changes to the integration test.
RSLGTM on changes to flutter tooling.
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #9580
Reverts #9719
Only run pod install if the user uses pulls in pods via pub and plugins.
Also removes all references of the channel integration test's dependencies on cocoapods since the artifacts checked in were partial and wouldn't build without a first pod install even though it doesn't actually use cocoapods. (some context/assumptions in #9621)