Update stretching overscroll clip behavior#97678
Merged
Piinks merged 3 commits intoflutter:masterfrom Feb 18, 2022
Merged
Conversation
Piinks
added
framework
chunhtai
approved these changes
Feb 15, 2022
packages/flutter/test/widgets/overscroll_stretch_indicator_test.dart
Outdated
Show resolved
Hide resolved
Piinks
commented
Feb 16, 2022
packages/flutter/test/widgets/overscroll_stretch_indicator_test.dart
Outdated
Show resolved
Hide resolved
Piinks
commented
Feb 16, 2022
packages/flutter/test/widgets/overscroll_stretch_indicator_test.dart
Outdated
Show resolved
Hide resolved
Contributor
Author
|
FroB seems to have lost this PR, I found the cl it generated and it passed, but FroB will not allow me to set it green since it cannot find it. Manually merging. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 18, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 18, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 18, 2022
clocksmith
pushed a commit
to clocksmith/flutter
that referenced
this pull request
Mar 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #95593
Fixes #97867
Now that Clip.none is a valid clipBehavior for ClipRect, we can update the stretching overscroll indicator to resolve internal customer issue b/210103825
This issue pointed out that state deactivation was happening in the customer's scroll view because the clipping widget was being removed from the tree, rather than just modifying the clip behavior, forcing everything to be rebuilt.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.