Relax android semantics integration test checks#97742
Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom Feb 11, 2022
Merged
Relax android semantics integration test checks#97742fluttergithubbot merged 1 commit intoflutter:masterfrom
fluttergithubbot merged 1 commit intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
a: accessibility
Contributor
Author
|
friendly bump |
jonahwilliams
approved these changes
Feb 9, 2022
| ], | ||
| // We can't predict the a11y focus when the screen changes. | ||
| ignoredActions: ignoredAccessibilityFocusActions | ||
| ignoredActions: ignoredAccessibilityFocusActions, |
Contributor
There was a problem hiding this comment.
Do we have an issue filled for this? Is it something that could be fixable eventually? Would be good to link here.
Contributor
Author
There was a problem hiding this comment.
I don't think this can be fixable, Android does not guarantee accessibility focus in talkback.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 11, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 11, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 11, 2022
clocksmith
pushed a commit
to clocksmith/flutter
that referenced
this pull request
Mar 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test is flaked on more places whether it check for accessibility action. Since the android a11y focus system is unpredictable, I relax the test checks on those places.
fixes #97666
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.