use 'dart pub' instead of calling the pub executable directly#97749
use 'dart pub' instead of calling the pub executable directly#97749devoncarew merged 2 commits intoflutter:masterfrom
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
flutter-dashboard
bot
added
the
c: contributor-productivity
|
I can't tell whether this PR is test-exempt or not; it will be exercised by the CI as part of the doc generation process. |
|
I don't think it's test exempt. There already is a test for this script at https://github.com/flutter/flutter/blob/master/dev/tools/test/dartdoc_test.dart You could add a test in there with the fake process manager that makes sure it calls "dart pub" as part of an operation. |
|
It might help to refactor some of those calls into separate functions, and test those functions in isolation. It's a pretty huge |
|
Gotcha, thanks! I introduced a small abstraction - a |
…r#97749) use 'dart pub' instead of calling the pub executable directly
3 participants
pubexecutable is being deprecated)List which issues are fixed by this PR. You must list at least one issue.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
n/a
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.