[framework] dont hit test for systemnav style if there is no bottom window padding#97771
[framework] dont hit test for systemnav style if there is no bottom window padding#97771jonahwilliams wants to merge 26 commits intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
f: cupertino
| // bottom drawn pixel is at 1919 position. | ||
| bounds.bottom - 1.0 - _window.padding.bottom / 2.0, | ||
| ); | ||
| final SystemUiOverlayStyle? upperOverlayStyle = layer!.find<SystemUiOverlayStyle>(top); |
There was a problem hiding this comment.
Would the same logic apply to the system status bar? Can this be skipped if there isn't viewPadding at the top?
There was a problem hiding this comment.
Good idea, let me check that...
There was a problem hiding this comment.
can you hide this on iOS or just Android?
There was a problem hiding this comment.
I'll follow up with this one another time
|
g3 testing failures are due to binding change, I'll wait til that is resolved then rebase |
|
or maybe it is already fixed... |
…r into benchy_mc_benchface
…r#97749) use 'dart pub' instead of calling the pub executable directly
Supports the desktop text editing interaction of holding shift, tapping the field, and dragging to modify the selection.
|
So I have failing google3 tests due to the Bindings change, but I already pulled latest. how do I get frob to use a different base commit - do I need to rebase? |
|
I don't think there is a way for frob to do that. I think you just have to wait until that change rolled into google3, unfortunately. @renyou would know for sure. |
…y module App.framework (flutter#97689)
…duleForcedFrame`. (flutter#97468)
…r into benchy_mc_benchface
12 participants
This means there is no bottom navigation bar, so the hit test is wasted. (at least, I think so...)