Skip to content

Fix how Gradle resolves Android plugin#97823

Merged
fluttergithubbot merged 6 commits intoflutter:masterfrom
blasten:fix_gradle_plugin_resol
Feb 7, 2022
Merged

Fix how Gradle resolves Android plugin#97823
fluttergithubbot merged 6 commits intoflutter:masterfrom
blasten:fix_gradle_plugin_resol

Conversation

@blasten
Copy link

@blasten blasten commented Feb 4, 2022

Fixes #97729

When the tool migrated to .flutter-plugins-dependencies, the Gradle plugin was never changed.
Until now, the plugin had the heuristic that a plugin with a android/build.gradle file supported the Android platform.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Feb 4, 2022
Emmanuel Garcia added 2 commits February 4, 2022 11:23
@flutter flutter deleted a comment from flutter-dashboard bot Feb 4, 2022
Emmanuel Garcia added 2 commits February 4, 2022 12:03
stuartmorgan-g
stuartmorgan-g approved these changes Feb 7, 2022
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit 965397c into flutter:master Feb 7, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 7, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2022
@engine-flutter-autoroll
965397c Fix how Gradle resolves Android plugin (flutter/flutter#97823)
f095de5
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 7, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2022
@engine-flutter-autoroll
965397c Fix how Gradle resolves Android plugin (flutter/flutter#97823)
956c8c7
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 7, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2022
@engine-flutter-autoroll
965397c Fix how Gradle resolves Android plugin (flutter/flutter#97823)
8d0da5d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
965397c Fix how Gradle resolves Android plugin (flutter/flutter#97823)
a276b55
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
965397c Fix how Gradle resolves Android plugin (flutter/flutter#97823)
7ead2cd
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
965397c Fix how Gradle resolves Android plugin (flutter/flutter#97823)
db16224
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
965397c Fix how Gradle resolves Android plugin (flutter/flutter#97823)
2ef5c6c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
965397c Fix how Gradle resolves Android plugin (flutter/flutter#97823)
c96c048
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
965397c Fix how Gradle resolves Android plugin (flutter/flutter#97823)
4f457e5
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
965397c Fix how Gradle resolves Android plugin (flutter/flutter#97823)
a884310
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
965397c Fix how Gradle resolves Android plugin (flutter/flutter#97823)
a21be50
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
965397c Fix how Gradle resolves Android plugin (flutter/flutter#97823)
6896dd3
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
965397c Fix how Gradle resolves Android plugin (flutter/flutter#97823)
41b736e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
965397c Fix how Gradle resolves Android plugin (flutter/flutter#97823)
f9d6cea
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
965397c Fix how Gradle resolves Android plugin (flutter/flutter#97823)
f9669f1
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
965397c Fix how Gradle resolves Android plugin (flutter/flutter#97823)
6ef721f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
965397c Fix how Gradle resolves Android plugin (flutter/flutter#97823)
1ef7499
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
965397c Fix how Gradle resolves Android plugin (flutter/flutter#97823)
b81dcac
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
965397c Fix how Gradle resolves Android plugin (flutter/flutter#97823)
b903e94
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
965397c Fix how Gradle resolves Android plugin (flutter/flutter#97823)
136e7fe
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
965397c Fix how Gradle resolves Android plugin (flutter/flutter#97823)
219d584
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
965397c Fix how Gradle resolves Android plugin (flutter/flutter#97823)
4b0b18c
@Gustl22
Copy link
Contributor

Gustl22 commented Oct 23, 2023

Reverted in #98050

@Gustl22 Gustl22 mentioned this pull request Oct 24, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

@camsim99 camsim99 Awaiting requested review from camsim99

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unable to run Android app on stable 2.10 if it uses a plugin with an android folder but no Android support

4 participants

@blasten @Gustl22 @stuartmorgan-g @fluttergithubbot