Expose smart punctuation options on CupertinoSearchTextField#97980
Merged
auto-submit[bot] merged 4 commits intoflutter:masterfrom Jun 22, 2022
Merged
Expose smart punctuation options on CupertinoSearchTextField#97980auto-submit[bot] merged 4 commits intoflutter:masterfrom
auto-submit[bot] merged 4 commits intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
f: cupertino
moffatman
force-pushed
the
search_field_quotes
branch
from
408a051 to
e45e38a
Compare
moffatman
force-pushed
the
search_field_quotes
branch
from
2997339 to
d183177
Compare
moffatman
force-pushed
the
search_field_quotes
branch
from
d183177 to
b9c431d
Compare
moffatman
force-pushed
the
search_field_quotes
branch
from
b9c431d to
48ecffd
Compare
|
Gold has detected about 1 new digest(s) on patchset 3. |
moffatman
force-pushed
the
search_field_quotes
branch
from
48ecffd to
e5b9042
Compare
moffatman
force-pushed
the
search_field_quotes
branch
from
e5b9042 to
5437dec
Compare
guidezpl
requested changes
May 2, 2022
Member
guidezpl
left a comment
guidezpl
left a comment
There was a problem hiding this comment.
Not at all familiar with this mechanism, but this needs a test to validate behavior.
Contributor
Author
|
@guidezpl There is a test here, it's just a change to pass-through an option to a child Widget. |
guidezpl
approved these changes
May 2, 2022
Member
guidezpl
left a comment
guidezpl
left a comment
There was a problem hiding this comment.
I shouldn't review on my phone :). LGTM
moffatman
force-pushed
the
search_field_quotes
branch
from
5437dec to
37d0d35
Compare
Member
|
Running Google testing again |
Contributor
Author
|
@guidezpl Can you press the merge button? |
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
Contributor
Author
|
@guidezpl Guess it needs 1 more approval |
Member
|
Can you post a link in the Discord for a review? |
LongCatIsLooong
approved these changes
Jun 16, 2022
| /// character will be automatically replaced by a left or right double quote | ||
| /// depending on its position in a word. | ||
| /// | ||
| /// Defaults to true. |
Contributor
There was a problem hiding this comment.
nit: something like "Defaults to null which uses the default smart quote behavior specified on the platform"?
Same for smart dashes.
Contributor
Author
There was a problem hiding this comment.
Actually looked into it, the default platform behavior is never used. It will either be forced to yes or no. But I updated the comment to explain that.
moffatman
force-pushed
the
search_field_quotes
branch
from
37d0d35 to
82bae95
Compare
Contributor
Author
|
@guidezpl Can you now press the merge button? |
guidezpl
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jun 22, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 22, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jun 22, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jun 22, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jun 22, 2022
camsim99
pushed a commit
to camsim99/flutter
that referenced
this pull request
Aug 10, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let users of
CupertinoSearchTextFieldchoose to disable automatic directional quotes, en-dashes, and em-dashes.Fixes #102058
Pre-launch Checklist
///).